Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Filesystem Header and Add Centered "Hello SFML" Text #2

Merged
merged 15 commits into from
Jan 22, 2024

Conversation

vor1c
Copy link
Contributor

@vor1c vor1c commented Jan 22, 2024

This pull request includes two changes: first, the update of #include to #include <experimental/filesystem> for compatibility; second, the addition of a centered "Hello SFML" text in white, using a pre-installed font overlaid on an image in the SFML project. These changes collectively enhance compatibility and introduce a visually appealing element to the project.

  • i added the Arial.ttf for a font!

@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

btw goated Template!

Copy link
Owner

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @therealvoric, this is a nice PR, but needs some more changes.

Also, I didn't quite understand the reason behind using experimental/filesystem. If I am not wrong, using filesystem should be fine with all C++17 compilers (at least the major ones).

resources/arial.ttf Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

So I changed all Requests...

@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

btw sorry for the late reply!

Copy link
Owner

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes needed🙂

src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

working now!
i changed everything needed

@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

should be working now?

@ufrshubham
Copy link
Owner

should be working now?

It works, but the text looks too odd:
image

I think I'll merge your PR for now and push some more change to fix this

@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

window size 800x600?

@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

would fix

@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

grafik

@ufrshubham
Copy link
Owner

Since having an image and the Hello SFML both at the same time didn't make much sense, I replaced the whole thing with this
image

This is generated on the fly, so there is no need for a separate Hello SFML text.

@ufrshubham ufrshubham merged commit 88c50cf into ufrshubham:main Jan 22, 2024
3 checks passed
@vor1c
Copy link
Contributor Author

vor1c commented Jan 22, 2024

nice thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants