Add MEGAN2 BVOC emission process #111
Conversation
…TChem into feature/catchem_begins
@zmoon Do you mean the warning below? I am not sure how it happens. Could you help me get rid of it? CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake. Update the VERSION argument value or use a ... suffix to tell CMake that the project does not need compatibility with older versions. |
Not that one, we can address that later, it's not related to your PR. I was talking about the warnings from the compiler: For example with gfortran-11 |
Oh ok. It seems to have some unused variables. I can clean them. But I guess we should keep the unused 'chemstate' and 'diagstate' for future use? |
If it's something you are reasonably sure may be used in the future, you can comment the declaration out instead of fully removing it (but still remove it from arguments if necessary to resolve the warning). And if you have "equality comparison for real" warning, you can use the |
zmoon
force-pushed
the
feature/catchem_begins
branch
from
53ad0f7 to
12d57c6
Compare
zmoon
force-pushed
the
feature/catchem_begins
branch
from
12d57c6 to
1bda156
Compare
@bbakernoaa The historical accumulation function is added with the new commit and saved to DiagState. I think it is better to be saved to restart files if we have that functionality created in the future. The time step is needed to add the historical effect. I am using the MetState TSTEP for now and not sure if a TSTEP is also necessary for EmisState. Another thing I noticed is the temperature historical effect is deactivated by Silva but the historical PAR is still used. |
|
@lwcugb I think it will but remember that CATChem is a column model and that the interface will pass that to the host model to be written out. It is also something that could be read in through the host model as well. TSTEP would be the correct variable. We could add an option flag to turn the effects on or off. Do you think that would be beneficial? |
Silva's paper suggests that the emissions are only slightly lower. Maybe his other edits make up for the historical temperature or the impact itself is small in the default algorithm (historical PAR may be more important?). So I guess it may not benefit a lot if we keep Silva's method. |
src/core/config_mod.F90
Outdated
| IF ( RC /= CC_SUCCESS ) THEN | ||
| errMsg = TRIM( key ) // 'Not Found, Setting Default to 390.0' | ||
| ENDIF | ||
| ! write(*,*) v_real |
There was a problem hiding this comment.
| ! write(*,*) v_real |
| v_real = MISSING_REAL | ||
| CALL QFYAML_Add_Get( ConfigInput, TRIM( key ), v_real, "", RC ) | ||
| IF ( RC /= CC_SUCCESS ) THEN | ||
| errMsg = TRIM( key ) // 'Not Found, Setting Default to 390.0' |
There was a problem hiding this comment.
This message is never printed
There was a problem hiding this comment.
Add CC_Error subroutine below the errMsg.
src/core/config_mod.F90
Outdated
| CALL QFYAML_Add_Get( ConfigInput, TRIM( key ), v_int, "", RC ) | ||
| IF ( RC /= CC_SUCCESS ) THEN | ||
| errMsg = TRIM( key ) // 'Not Found, Setting Default to 1' | ||
| RETURN |
There was a problem hiding this comment.
| RETURN |
Otherwise the code below won't run
| v_int = MISSING_INT | ||
| CALL QFYAML_Add_Get( ConfigInput, TRIM( key ), v_int, "", RC ) | ||
| IF ( RC /= CC_SUCCESS ) THEN | ||
| errMsg = TRIM( key ) // 'Not Found, Setting Default to 1' |
There was a problem hiding this comment.
This message is never printed
There was a problem hiding this comment.
Add CC_Error subroutine below the errMsg.
…TChem into feature/catchem_begins
This pull request adds the MEGAN2.1 BVOC emission scheme based on its implementation in HEMCO.