changed build system to accomodate name change of bacio library in bacio-2.5.0 release #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
changed the title
|
@edwardhartnett We want to move UFS_UTILS from NOAA-EMC to ufs-community. To simplify the move, we don't want any open PRs. Can you close this, then reopen it after the move? |
|
Temporarily close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589
In the bacio-2.5.0 release (Oct 20, 2021) the name of the bacio library and include directory change to no longer include the "_4".
In this PR I change the UFS_UTILS build to handle this. The version of bacio is checked in the top-level CMake file, and cmake variable bacio_name is set to either "bacio" or "bacio_4", depending on the bacio version. All other cmake files which use bacio have the name changed to ${bacio_name}.
I will add a github action which tests against the develop branch of bacio to ensure that UFS_UTILS keeps working with both old and new versions of the bacio library.