First reconciliation PR from production/RRFS.v1 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd it will be consistent with convective precipitation"
grantfirl
force-pushed
the
rrfsv1-to-ufs/dev1
branch
from
5b27a47
to
14afff2
Compare
This was referenced Oct 4, 2024
dustinswales
reviewed
Oct 4, 2024
| @@ -4118,7 +4119,7 @@ subroutine cup_output_ens_3d(xff_mid,xf_ens,ierr,dellat,dellaq,dellaqc, & | |||
| ,intent (inout) :: & | |||
| ierr,ierr2,ierr3 | |||
| integer, intent(in) :: dicycle | |||
| real(kind=kind_phys), intent(in), dimension (its:ite) :: xf_dicycle | |||
| real(kind=kind_phys), intent(in), dimension (its:ite) :: xf_dicycle, rrfs_factor | |||
| !$acc declare copyin(zu,pwd,p_cup,sig,xmbm_in,xmbs_in,edt,xff_mid,dellat,dellaqc,dellaq,pw,ktop,xland1,xf_dicycle) | |||
There was a problem hiding this comment.
Maybe irrelevant, but if xf_dicycle is part to the $acc directive, should rrfs_factor be added?
There was a problem hiding this comment.
@dustinswales If this caused a problem, do you think that this type of thing would be caught in the SCM nvhpc CI test? Just curious. I.e. is this something that the compiler would catch or would it just be a run-time issue (failure or performance hit)?
There was a problem hiding this comment.
I have no clue if this would get caught at buildtime/runtime.
grantfirl
requested review from
haiqinli,
rhaesung,
Qingfu-Liu,
tanyasmirnova and
joeolson42
as code owners
tanyasmirnova
approved these changes
Oct 9, 2024
rhaesung
approved these changes
Oct 10, 2024
|
Tests are done at ufs-community/ufs-weather-model#2449. @rhaesung @dustinswales can you merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the original PR from @haiqinli for the production/RRFS.v1 branch:
#176
on top of the latest ufs/dev branch.
Note that the changes to drag_suite.F90 have been superceded by changes already in ufs/dev.