Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue on multiple log files with same prefix in plot_stats #168

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix issue on multiple log files with same prefix in plot_stats #168

merged 3 commits into from
Nov 12, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Oct 31, 2024 •
edited
Loading

Description

  • Fix the issue on the multiple log files with the same prefix but no result values for the 'plot_stats' task.
  • Fix the issue on the cold start of the ufs-weather-model in the forecast task.

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • apply_incr.fd (NOAA-PSL/land-apply_jedi_incr)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • none

Linked PR's and Issues:

Resolve Issue #165

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Hercules
  • CI
    • Completed
  • WE2E
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@chan-hoo
Copy link
Collaborator Author

@EdwardSnyder-NOAA, I believe this PR can resolve your issue. Please test it and let me know what you think.

@chan-hoo chan-hoo linked an issue Oct 31, 2024 that may be closed by this pull request
Plotting stats task bug #165
Closed
EdwardSnyder-NOAA
EdwardSnyder-NOAA approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@EdwardSnyder-NOAA EdwardSnyder-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I tested it on Orion with extra analysis log files, and the script behaved as expected.

@chan-hoo chan-hoo merged commit 555b708 into ufs-community:develop Nov 12, 2024
2 checks passed
chan-hoo added a commit to chan-hoo/land-DA_workflow that referenced this pull request Nov 12, 2024
@chan-hoo
Fix issue on multiple log files with same prefix in plot_stats (ufs-c…
207a3f0 
…ommunity#168)

* fix issues on multiple log files

* update detect_platform script

* fix coldstart of forecast
@chan-hoo chan-hoo mentioned this pull request Nov 12, 2024
Merged
12 tasks
chan-hoo added a commit that referenced this pull request Nov 13, 2024
@chan-hoo
Fix issue on multiple log files with same prefix in plot_stats (#168) (…
df92f8b 
…#169)

* fix issues on multiple log files

* update detect_platform script

* fix coldstart of forecast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwardSnyder-NOAA EdwardSnyder-NOAA EdwardSnyder-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotting stats task bug
3 participants
@chan-hoo @jkbk2004 @EdwardSnyder-NOAA