Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aqm_dev] Changes for UFS-SRW-AQM with CMAQv5.4 #1106

Draft
wants to merge 6 commits into
base: aqm_dev
Choose a base branch
from

Conversation

drnimbusrain
Copy link

@drnimbusrain drnimbusrain commented Jul 19, 2024

DESCRIPTION OF CHANGES:

This PR contains commits necessary for updating the UFS-SRW-App [aqm_dev] workflow to use the AQM with associated updates to use CMAQv5.4. See PR to EMC's AQM repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [X ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
    More information: Merging these changes will break running UFS-SRW-AQMv7 with [aqm_dev] branch.
  • [ X] This change requires a documentation update

TESTS CONDUCTED:

  • [X ] hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

There will be a need UWM PR that points to updated EMC AQM hash for updated CMAQv5.4, once merged. See PR to EMC's AQM repository.

New fix files are necessary to run this updated workflow (see changes to aqm.rc below).

DOCUMENTATION:

ISSUE:

#1105

CHECKLIST

  • [ X] My code follows the style guidelines in the Contributor's Guide
  • [X ] I have performed a self-review of my own code using the Code Reviewer's Guide
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • [X ] Work In Progress
  • bug
  • [ X] enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • [ X] help wanted

CONTRIBUTORS (optional):

@lwcugb @bbakernoaa @ytangnoaa

lwcugb and others added 3 commits January 5, 2024 10:52
add aqm.rc, diag_table_aqm.FV3_GFS_v16 and field_table_aqm.FV3_GFS_v16
point to ARL ufs-weather-model  feature/cmaq54
Re-updated ufs-weather-model to point to AQM/cmaq5.4 version.
@drnimbusrain drnimbusrain marked this pull request as draft July 26, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants