-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Bugfix bonanza #1108
Closed
Closed
[develop] Bugfix bonanza #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the tar file where the prepbufr files live changed"
…y Michelle Harrold, solution by Michael Kavulich.
…ntStat tasks' METplus log files.
…ing cycles for CCPA and MRMS but not yet for NDAS or NOHRSC.
…thout performing unnecessary repeated pulls.
… they're per-cycle or per-day.
…nup and comments.
…files from HPSS (and works with multiple cycles).
…e cleanup is happening.
…les, that are expected to be created once the task is finished actually get created. This is needed because it is possible that for some forecast hours for which there is overlap between cycles, the files are being retrieved and processed by the get_obs_... task for another cycle.
…nd EnsembleStat tasks such that GenEnsProd does not depend on the completion of get_obs_... tasks (because it doesn't need observations) but only forecast output while EnsembleStat does.
…d due to changes to dependencies of GenEnsProd tasks in previous commit(s).
…tending to time out for 48-hour forecasts.
…sure PcpCombine operates only on those hours unique to the cycle, i.e. for those times starting from the initial time of the cycle to just before the initial time of the next cycle. For the PcpCombine_obs task for the last cycle, allow it to operate on all hours of that cycle's forecast. This ensures that the PcpCombine tasks for the various cycles do not clobber each other's output. Accordingly, change the dependencies of downstream tasks that depend on PcpCombine obs output to make sure they include all PcpCombine_obs tasks that cover the forecast period of the that downstream task's cycle.
…ossibly also get_obs_ndas by putting in sleep commands.
@MichaelLueken I would like to close this draft PR and open a new one since I'm actually using a different branch for my work than |
@gsketefian - Sure, no problem. Please feel free to close this PR and open a new one from your new branch. |
@MichaelLueken Great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR fixes several bugs discovered in the verification portion of the app during recent testing by the DTC. The bugs are:
Change to
parm/data_locations.yml
to account for the change in prebpufr (NDAS) obs file names on May 22, 2024. This is currently causingget_obs_ndas
tasks to fail for cycles at or after this date. [Bug found by @michelleharrold.]Change to
parm/wflow/verify_det.yaml
so that all tasks have acycldefs
statement by default. This bug was causingGridStat
workflow tasks forCCPA
andNOHRSC
obs to be created for cycles not defined for the workflow (these extraneous cycles probably correspond to the default set of cycles that a task gets assigned byROCOTO
when it does not contain an explicitcycledefs
statement). [Bug found by @michelleharrold, solution by @mkavulich.]Change to
scripts/exregional_run_met_gridstat_or_pointstat.sh
to append a string for the cycle date ("_YYYYMDDHH") to the name of the metplus log file for deterministicGridStat
andPointStat
tasks. This was causing the metplus log file for GridStat for a given cycle tasks to be overwritten by those for other cycles. [Bug found by @michelleharrold.]Refactoring of
scripts/exregional_get_verif_obs.sh
to account for multiple overlapping cycles. It was found that when the experiment contains multiple cycles, theget_obs_ccpa
,get_obs_mrms
, andget_obs_ndas
from the different cycles write to the same directories and clobber the output of other cycles or cause crashes (e.g. a directory is not empty when it is expected to be). [Bug found by @michelleharrold and @willmayfield.]. This script is refactored so that:a) "Raw" directories, i.e. the directories in which the data is pulled by the
retrieve_data.py
script, for each cycle or observation day are unique (contain either the cycle (raw_cycYYYYMMDDHH
) or the date (raw_dayYYYYMMDD
) in their names). Whether a cycle-based or obs-day-based raw directory is used depends on the obs type: CCPA raw directories are cycle-based, and MRMS and NDAS raw directories are day-based.b) There are checks on directories and files to make sure the
get_obs_...
task for another cycle is not writing to the directory and/or file the current cycle wishes to modify (write to, move, delete, etc).c) Data pulls and the final set of processed observations are organized so that there are no extra observation files that lie outside the range of the forecasts.
d) Extra documentation is included in the script to describe in detail the behavior of the script for each obs type (CCPA, MRMS, NDAS).
Type of change
TESTS CONDUCTED:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):