Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GW-RT global_control.nml modifications #2425

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

dpsarmie
Copy link
Collaborator

@dpsarmie dpsarmie commented Sep 3, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR will modify the global_control.nml to add variables that are present in the Global Workflow scripts but not currently present in the RTs. Some variables will also be changed from constants to variable placeholders. This will allow Global Workflow to use the global_control.nml as a template for their operations.

Another issue will also be merged into this PR. The cpld_control_sfs configuration will be changed to bring it in-line with the GW configuration.

This PR is now also going to include a fix for #2443. This will add additional baseline changes that are unrelated to the initial global_control.nml modifications or the sfs configuration fix.

Commit Message:

* UFSWM - Modify global_control.nml to add compatibility with Global Workflow

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • cpld_control_sfs

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

dpsarmie and others added 2 commits August 30, 2024 23:49
This adds new options to the namelist that are used and
dynamic in the global workflow. This is to prepare the RT namelist
for the RT-GW bridge PR.
@dpsarmie dpsarmie marked this pull request as ready for review September 6, 2024 18:01
This commit changes a couple of the parameters in
cpld_control_sfs to bring it in line with the Global
Workflow parameter values.
@dpsarmie dpsarmie added the Baseline Updates Current baselines will be updated. label Sep 16, 2024
@dpsarmie dpsarmie marked this pull request as draft September 17, 2024 15:49
dpsarmie and others added 2 commits September 20, 2024 08:07
This commit addresses the issue in default_vars.sh where
ATMRES is reset in the export_cpl() call to C96.
Default values will now only be set if the resolutions have
not been previously set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ATMRES getting reset in export_cpl() Modify global_control.nml to work with GW scripts
3 participants