-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unity normalization in CMEPS for coupled fields #522
Merged
DeniseWorthen
merged 37 commits into
ufs-community:develop
from
DeniseWorthen:feature/unity_normalization
Apr 27, 2021
Merged
Implement unity normalization in CMEPS for coupled fields #522
DeniseWorthen
merged 37 commits into
ufs-community:develop
from
DeniseWorthen:feature/unity_normalization
Apr 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeniseWorthen
changed the title
Feature/unity normalization
Implement unity normalization
Apr 15, 2021
DeniseWorthen
changed the title
Implement unity normalization
Implement unity normalization in CMEPS for coupled fields
Apr 15, 2021
DeniseWorthen
added
the
Waiting for Reviews
The PR is waiting for reviews from associated component PR's.
label
Apr 20, 2021
DeniseWorthen
requested review from
junwang-noaa,
DusanJovic-NOAA,
climbfuji and
MinsukJi-NOAA
April 20, 2021 16:23
climbfuji
approved these changes
Apr 27, 2021
junwang-noaa
approved these changes
Apr 27, 2021
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
Use TEST_PREGEN_BASEDIR to set DOMAIN_PREGEN_BASEDIR if provided for a machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Baseline Updates
Current baselines will be updated.
Waiting for Reviews
The PR is waiting for reviews from associated component PR's.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Switches the mapping normalization type for coupled fields to
one
. See item 1 in CMEPS Issue #38 for more information.The implementation of unity normalization results in b4b differences in the first coupling timestep of the coupled model. These differences are on the same order as a butterfly effect. See testing results here for more information.
Issue(s) addressed
CMEPS Issue, Item 1: #38
CMEPS Issue: #40
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Initial testing:
hera.gnu: no change to current baselines
hera.intel: a test baseline was created for the coupled and datm tests; all coupled and datm tests verified against this test baseline.
Dependencies
Waiting on CMEPS PR #41