Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unity normalization in CMEPS for coupled fields #522

Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 15, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Switches the mapping normalization type for coupled fields to one. See item 1 in CMEPS Issue #38 for more information.

The implementation of unity normalization results in b4b differences in the first coupling timestep of the coupled model. These differences are on the same order as a butterfly effect. See testing results here for more information.

Issue(s) addressed

CMEPS Issue, Item 1: #38
CMEPS Issue: #40

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Initial testing:

hera.gnu: no change to current baselines
hera.intel: a test baseline was created for the coupled and datm tests; all coupled and datm tests verified against this test baseline.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

Waiting on CMEPS PR #41

@DeniseWorthen DeniseWorthen changed the title Feature/unity normalization Implement unity normalization Apr 15, 2021
@DeniseWorthen DeniseWorthen changed the title Implement unity normalization Implement unity normalization in CMEPS for coupled fields Apr 15, 2021
@DeniseWorthen DeniseWorthen marked this pull request as ready for review April 15, 2021 13:19
@DeniseWorthen DeniseWorthen added the Baseline Updates Current baselines will be updated. label Apr 15, 2021
@DeniseWorthen DeniseWorthen self-assigned this Apr 15, 2021
@DeniseWorthen DeniseWorthen added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Apr 20, 2021
@DeniseWorthen DeniseWorthen merged commit 390a14f into ufs-community:develop Apr 27, 2021
@DeniseWorthen DeniseWorthen deleted the feature/unity_normalization branch May 7, 2021 11:57
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Use TEST_PREGEN_BASEDIR to set DOMAIN_PREGEN_BASEDIR if provided for a
machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants