Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up input-data directories; Fix MERRA2 input; Add tests on Jet; Update CICE cap & fix time manager (was PR#664) #639
Clean up input-data directories; Fix MERRA2 input; Add tests on Jet; Update CICE cap & fix time manager (was PR#664) #639
Changes from all commits
7b826d4
cea6fc6
071275b
4db2ff2
5a8d4b6
09716fe
f778ec2
3ae6d69
f187e64
94f5e67
4100179
42d1a64
8a5575b
9a06325
6ba165f
1602558
2208dea
217e3f0
c553a61
52625f5
a248612
9a80b95
2ad32ab
258dc4e
20210f7
750b914
4f02568
a3fd6ad
4a082c0
8ff5a46
a66de98
9d13add
41e1e70
a04c704
9e624e3
54e8469
5a980fc
2c312c6
a43b484
31b0740
0e19119
e9a2e1f
ceaf7ea
f2cbf5a
5a786e2
2d1bdfd
f675d64
c89906d
489af4b
27b6c79
5d4216b
c0b7216
64e8b38
a9dc906
007a322
468a552
e32547f
128a986
9666be5
cf494c7
2e74cf4
c1f9ead
691d9eb
2718b15
563ff83
09d82a9
f85a79e
65b6184
2b2f344
fe262e4
ab12034
44abf46
c00af41
7102b14
90ccfa4
deaa174
41cc076
5548e13
1d016d8
32f1098
ac8b676
420ef5d
6effd4a
2734d78
dbaae91
3d86e14
a63b5c0
1572f15
2edff7c
8d69015
7b24162
415c1c7
89d6a02
ed14300
b305704
5051535
c69e4a2
b13d145
b074f72
f16dcb4
eeba35e
f540c3c
d976b93
ca68d2b
812c6d4
d874fca
5bd846a
d48d7cc
04a185c
88fb7c0
51f80e6
006d9cb
250809e
aad3e23
58fc91a
330bb0e
141df40
8a71739
ab4d8bf
3693630
1c2c2a5
1307753
0bf408b
ae4264a
aee060b
1389a89
7ab16ce
8e5e9d3
8d49d26
fc03655
979041f
8c06191
d4c510a
4e5cdc5
77b4827
893b2b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ICs that are needed for the develop branch are not the "p6" ICs. On one hand, I don't think its important but on the other hand, I don't want people to think it's p6 when it's not. Also these ICs will occasionally change. One thing we could do is put the date of the WW3 commit that it corresponds to? I think it's good to have this subfolder though because we can add another folder and then just update this instead of having to do a completely new INPUTDATA_ROOT_BMIC unless that's what we want every time the WW3 IC has to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were copied from the existing FV3_input_frac/BM_IC wave inputs. I realize they are probably not what was used in P6. I actually thought about leaving the entire wave/p6 directory out because they are used only for the 35d runs, and we will not be making any P6 35d runs from the RTs. However, we're still carrying the
cpld_bmark_wave_v16_35d
which requires something for the WW3 ICs. I think maybe the best solution is to remove that 35d script and the wav_p6 directory also. We are still carrying the v16 RTs, so we need the ATM ICs.The wave ICs will not be updated each time WW3 changes the format etc of restarts. They are used only for the 35d runs, so would not be updated until the next Prototype was being set up. At that time, we'll probably have new ATM ICs also, from which the WW3 ICs can be generated. I don't think we need a dated WW3 IC sub-directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the discussion at this morning's tag-up, I will be removing all but the 2013040100 P6 ATM ICs. These ICs are required to run the current v16 benchmark RTs. No wave ICs are required. I will also remove the non-p7 35d scripts.
This file was deleted.
This file was deleted.