Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scarlett's Assignment 1 submission #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

hs4man21
Copy link
Collaborator

No description provided.

@@ -25,7 +25,7 @@
What are <h1> and </h1>? What if we replace them with something different? What happens if we remove one or both? Try it out!
-->

<h1>So you wanna set up a Stanford Daily email newsletter?</h1>
<p>yo wassup!</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha good stuff — love the paragraph tags!

Comment on lines +27 to +28
What happens? (color changes to black from) Then, change "the_title" to "not_the_title" up on the id of the h1 tag. Then what happens? (it goes back to red from black)
Write comment about your findings! - THe color changes when I put not the title below to black from red, but when I put not the title above, it turns back to red from black.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!

Comment on lines +67 to +72
outline-color: cornflowerblue;
font-family: cursive;
font-size: 100px;
color:#ffe5b4;
text-align: center;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice styling — if you ever forget what a CSS property does, remember that w3schools is a great resource!

Comment on lines +78 to +79
<p>I'm feeling very tired ackk.</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, just let us know if you want this program to be less of a work load!

@@ -15,7 +15,7 @@
Step 3.1

You might notice that the website's title is gold. Why is that?
You won't find any CSS in this file--so how is it possible for the text to be styled?
You won't find any CSS in this file--so how is it possible for the text to be styled? (using ids can help, and keeping the css in another file can clean the html up - scarlett)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great points!

padding: 10px;
margin: 10px;
margin: auto;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "auto" value was confusing to me for awhile haha

<div id="featured_fields3">
<span>Featured content headline</span>
<h1 id="the_title">Email Newsletter</h1>
<center><img style="width: 300px;height: 400px;margin-right: 15px;padding-top: 10px;"" src=https://i2.wp.com/www.vfxexpress.com/wp-content/uploads/2020/08/EnolaHolmes_KeyArt.jpg?fit=716%2C1060&ssl=1" alt="Enola Holmes Movie Poster"></center>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have extra quotation marks after the style attribute, and remember to make alt text descriptive, so ideally describe what is on the poster instead of just saying movie poster


<p1>Featured Content Excerpt:<textarea id="featured_content_excerpts"></textarea></p1></div>

<button onclick="alert('Turn in now?')">Turn in!</button>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alert is shown after the button is clicked, so if this "Turn in!" button shows an alert then there needs to be another button to confirm submission in a real-world scenario, right?

@@ -30,7 +45,7 @@ <h1 id="the_title">So you wanna set up a Stanford Daily email newsletter?</h1>
id "featured_fields3" and that corresponding styling in step7.css. As you might guess, this means
that we want you to also add "featured_fields2" and "featured_fields1" id selectors to the css file.
correspondingly, you'll want the first article's div in each group of 3 to have the id "featured_fields1",
the second article's div to have "featured_fields2", etc. You should also use CSS to make the color of
the second article's div to have "featured_fields2", etc. (i renamed them article1, article2, cuz i felt the name was too long to type heh - scarlett) You should also use CSS to make the color of
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Can you think of a way we might be able to automate the incremented id assignment in JSX?

Comment on lines +2 to +88
padding-top: 10px;
padding-bottom: 10px;
text-align: center;
margin: auto;
color: plum;
border-style: dotted;
border-color: blueviolet;
width: 30%;
font-family: Impact, Haettenschweiler, 'Arial Narrow Bold', sans-serif;
}

#article1 {
display: inline-block;
padding: 10px;
margin-left: 120px;
border-style: solid;
border-color: rgb(240, 198, 170);
border-radius: 25px;
background-color:lightyellow;
width: 100px
}
#article2 {
display: inline-block;
padding: 10px;
margin-left: 10px;
border-style: solid;
border-color: #dbd19a;
border-radius: 25px;
background-color: lightyellow;
width: 100px
}

#article3 {
display: inline-block;
padding: 10px;
margin-left: 10px;
border-style: solid;
border-color: #8fd8a1;
border-radius: 25px;
background-color: lightyellow;
width: 100px
}

#article4 {
display: inline-block;
padding: 10px;
margin-left: 10px;
text-align: center;
border-style: solid;
border-color: #95d4ec;
border-radius: 25px;
background-color: lightyellow;
width: 100px
}

#article5 {
display: inline-block;
padding: 10px;
margin-left: 10px;
border-style: solid;
border-color: #babbe9;
border-radius: 25px;
background-color: lightyellow;
width: 100px
}

#article6 {
display: inline-block;
padding: 10px;
margin-left: 10px;
border-style: solid;
border-color: #cf95dd;
border-radius: 25px;
background-color: lightyellow;
width: 100px
}

#featured_fields1 {
display: inline-block;
padding: 10px;
margin: auto;
border-style: solid;
border-color: rgb(208, 228, 245);
border-radius: 25px;
font-family: cursive;
background-color:rgba(236, 219, 240, 0.952);
width: 1398px
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are lots of styles shared between these different elements, you could consolidate the shared styles into a class and write them just once, and then assign the other styles by id!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants