Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combines searchGroupingMembers and getGroupingMembers endpoints #634

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

JorWo
Copy link
Contributor

@JorWo JorWo commented Jan 31, 2025

Ticket Link

GROUPINGS-1863

List of squashed commits

  • Moves numberOfGroupingMembers from GroupingsService to GroupingOwnerService
  • Fixes PascalCase use of SearchString into camelCase (searchString)
  • Fixes GroupingsRestControllerv2_1.updateOptAttribute in Swagger to use correct id

Test Checklist

  • Exhibits Clear Code Structure:
  • Project Unit Tests Passed:
  • Project Integration Tests Passed:
  • Executes Expected Functionality:
  • Tested For Incorrect/Unexpected Inputs:

@JorWo
Copy link
Contributor Author

JorWo commented Jan 31, 2025

The @Cacheable and @CacheEvict annotations uses Spring Boot's cache to simulate pagination. This allowed me to combine the two endpoints and simplify code in the React UI. Since GrouperClient does not have pagination support when searching for members in a group by a searchString, caching the result was the next best solution. Once an add/remove/reset happens to a groupPath, the cache evicts for the groupPath so the data returned is always correct.

I will wait for #624 to be completed before merging this.

@JorWo JorWo requested a review from mhodgesatuh January 31, 2025 02:38
@JorWo JorWo force-pushed the dev-jordanw4-1863 branch 2 times, most recently from 643681d to 566a003 Compare February 3, 2025 21:45
@JorWo JorWo force-pushed the dev-jordanw4-1863 branch from 566a003 to ab4c221 Compare February 3, 2025 22:03
@JorWo JorWo merged commit 6e84406 into uhawaii-system-its-ti-iam:main Feb 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants