New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor The GroupingsTable #101

Merged

JorWo merged 1 commit into main from dev-feimei-1832

Oct 22, 2024

Contributor

FeimeiChen commented Oct 16, 2024

Ticket Link

List of squashed commits

Commit 1:Refactor The GroupingsTable

Test Checklist

Unit Tests Passed
Integration Tests Passed
General Visual Inspection

FeimeiChen force-pushed the dev-feimei-1832 branch from 90de553 to bd5cd58 Compare

October 16, 2024 19:10

FeimeiChen requested a review from JorWo

October 16, 2024 19:11

FeimeiChen force-pushed the dev-feimei-1832 branch 2 times, most recently from 28649c5 to 2fb81d5 Compare

October 16, 2024 19:26

JorWo reviewed

View reviewed changes

ui/src/components/table/groupings-table.tsx Outdated Show resolved Hide resolved

JorWo reviewed

View reviewed changes

ui/src/components/table/table-element/groupings-table-columns.tsx Outdated Show resolved Hide resolved

JorWo reviewed

View reviewed changes

ui/src/components/table/table-element/grouping-path-cell.tsx Show resolved Hide resolved

JorWo reviewed

View reviewed changes

ui/tests/components/table/table-element/ grouping-description-cell.test.tsx Outdated Show resolved Hide resolved

JorWo reviewed

View reviewed changes

ui/src/components/table/table-element/grouping-path-cell.tsx Outdated Show resolved Hide resolved

Contributor

JorWo commented Oct 17, 2024

There also is a merge conflict.

FeimeiChen force-pushed the dev-feimei-1832 branch 2 times, most recently from 06b1a8f to 1d82285 Compare

October 19, 2024 00:59

FeimeiChen requested a review from JorWo

October 19, 2024 01:17

JorWo reviewed

View reviewed changes

ui/src/components/table/groupings-table-skeleton.tsx Show resolved Hide resolved


          Refactor The GroupingsTable

afa5723

FeimeiChen force-pushed the dev-feimei-1832 branch from 8f7881f to afa5723 Compare

October 21, 2024 19:02

FeimeiChen requested a review from JorWo

October 21, 2024 19:03

JorWo approved these changes

View reviewed changes

Contributor

JorWo left a comment

Thanks for the refactor

JorWo merged commit c6b357b into main

6 checks passed

JorWo deleted the dev-feimei-1832 branch

October 29, 2024 20:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet