Implement Manage Groupings #102

hokwaichan · 2024-10-17T09:14:05Z

Ticket Link

1728

List of squashed commits

Implement Manage Groupings

Test Checklist

Unit Tests Passed
Integration Tests Passed
General Visual Inspection

ui/src/app/groupings/[selectedGrouping]/@tab/all/page.tsx

JorWo · 2024-10-17T19:48:05Z

Could you add the styling for the All Members title and include the arrow like so?:

JorWo · 2024-10-17T19:50:12Z

The color of these icons should be #004252 and the circle should be slightly smaller.

JorWo · 2024-10-17T19:55:13Z

In path for /groupings/[selectedGrouping], let's rename [selectedGrouping] to [groupingPath] so that it is more clear.

JorWo · 2024-10-17T19:57:05Z

Could you add the rest of the routes (basis, include, exclude, owners, sync-destinations, preferences)? Thanks.

JorWo · 2024-10-17T20:02:03Z

Add this to next-config.mjs:

rewrites: async () => {
    return [
        {
            source: '/groupings/:groupingPath',
            destination: '/groupings/:groupingPath/all-members'
        }
    ];
}

This will map /groupings/tmp:jordanw4:jordanw4-aux to the same page as /groupings/tmp:jordanw4:jordanw4-aux/all-members. Helpful to avoid a 404 error.

ui/src/app/groupings/[selectedGrouping]/_components/grouping-header.tsx

ui/src/app/groupings/[selectedGrouping]/_components/return-buttons.tsx

ui/src/app/groupings/[selectedGrouping]/layout.tsx

JorWo · 2024-11-01T23:01:26Z

ui/tests/app/groupings/groupingPath/_components/grouping-header.test.tsx

@@ -0,0 +1,27 @@
+import React from 'react';


This can be removed.

JorWo · 2024-11-01T23:01:32Z

ui/tests/app/groupings/groupingPath/_components/return-buttons.test.tsx

@@ -0,0 +1,19 @@
+import React from 'react';


This can be removed.

JorWo · 2024-11-01T23:01:53Z

ui/tests/app/groupings/groupingPath/_components/side-nav.test.tsx

+import { render, screen } from '@testing-library/react';
+import SideNav from '@/app/groupings/[groupingPath]/_components/side-nav';
+import { usePathname } from 'next/navigation';
+import '@testing-library/jest-dom';


import '@testing-library/jest-dom' should not be needed.

JorWo · 2024-11-01T23:02:08Z

ui/tests/app/groupings/groupingPath/layout.test.tsx

@@ -0,0 +1,78 @@
+import {render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';


import '@testing-library/jest-dom' should not be needed. Also run Prettier formatter in here.

JorWo · 2024-11-02T03:23:03Z

ui/tests/app/groupings/groupingPath/layout.test.tsx

+                groupPath: 'Test-path:Test-name',
+                groupDescription: 'Test Description'
+            },
+            {}


This empty object might have been left here on accident.

hokwaichan requested a review from JorWo October 17, 2024 09:14