Fixed conditional statement for rendering of pageInfoItem.number #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a total fan of nested ternary operators, but maybe you could use the ?? operator instead? |
JorWo
reviewed
Jul 10, 2024
Comment on lines
110
to
112
| {pageInfoItem.number | ||
| && <span className="text-[2.5rem] text-text-color">{pageInfoItem.number}</span>} |
There was a problem hiding this comment.
{ pageInfoItem.number !== null might work too, not really sure how your 0 comes up as unstyled.
|
Ticket postponed because logic code shouldn't be in the UI and this problem has been identified as a possible API issue |
jarellb
force-pushed
the
dev-jarellab-1721
branch
from
397e3e7 to
102b0c4
Compare
jarellb
force-pushed
the
dev-jarellab-1721
branch
2 times, most recently
from
e17d977 to
41a3c1c
Compare
jarellb
force-pushed
the
dev-jarellab-1721
branch
from
41a3c1c to
5e03eda
Compare
JorWo
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
GROUPINGS-1721
List of squashed commits
Test Checklist