Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Font Awesome 5 #87

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Install Font Awesome 5 #87

merged 1 commit into from
Oct 17, 2024

Conversation

hokwaichan
Copy link
Contributor

Ticket Link

1792

List of squashed commits

  • Install Font Awesome 5

Test Checklist

  • Unit Tests Passed
  • Integration Tests Passed
  • General Visual Inspection

@hokwaichan hokwaichan requested a review from JorWo September 19, 2024 10:01
@JorWo
Copy link
Contributor

JorWo commented Sep 19, 2024

These icons are also FontAwesome but we decided to download them as SVGs to import into to project.
image
Could you replace id-card-solid.svg, key-solid.svg, user-solid.svg, and wrentch-solid.svg stored in /public? Thanks.

@hokwaichan hokwaichan force-pushed the dev-hokwai-1792 branch 3 times, most recently from a61480d to deddc33 Compare September 20, 2024 08:52
@JorWo
Copy link
Contributor

JorWo commented Sep 21, 2024

Now that the GroupingsTable is merged, could you also update that too? Thanks a lot.

@hokwaichan
Copy link
Contributor Author

Now that the GroupingsTable is merged, could you also update that too? Thanks a lot.

Would you also like to change the one in the dropdown menu and grouping-path-cell?

@hokwaichan hokwaichan force-pushed the dev-hokwai-1792 branch 2 times, most recently from a44d0c7 to dab489a Compare September 22, 2024 02:15
@JorWo
Copy link
Contributor

JorWo commented Sep 24, 2024

Now that the GroupingsTable is merged, could you also update that too? Thanks a lot.

Would you also like to change the one in the dropdown menu and grouping-path-cell?

Yes please, thanks.

@hokwaichan
Copy link
Contributor Author

Now that the GroupingsTable is merged, could you also update that too? Thanks a lot.

Would you also like to change the one in the dropdown menu and grouping-path-cell?

Yes please, thanks.

For the dropdown menu I couldn't find the buttons on the page, is there a way to display them?

@JorWo
Copy link
Contributor

JorWo commented Oct 1, 2024

Sorry, I meant this icon:
image

EDIT: If you are talking about writing the Jest tests, Feimei can help you troubleshoot that.

When I changed the icon to the same one as our angular (faSlidersH), it remained the same with the circle instead of square, do you have an idea why?

Copy link
Contributor

@JorWo JorWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the rest of the icons.

@JorWo JorWo merged commit 22f7c0e into main Oct 17, 2024
6 checks passed
@JorWo JorWo deleted the dev-hokwai-1792 branch October 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants