* [Issue 13] Remove unused imports and code. #1348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the code is used. Not sure what is the purpose of this PR ? Also in few places it replaces Rootshell implementation as well ? |
|
As written on the title, removed unused imports and code. |
|
I couldn't find the replaced Rootshell implementation... Do you mean the dropping of the (unused) result value assignment at: |
|
p.s. Again the added 'final' attributes are for development and debugging convenience... |
amaa-99
force-pushed
the
13-remove-unused-imports-and-code
branch
from
a51b434
to
6ff4539
Compare
Removed some of the unused imports and code.
amaa-99
force-pushed
the
13-remove-unused-imports-and-code
branch
from
6ff4539
to
d80506f
Compare
|
Could you please follow-up on this one? I think I've answered all your questions above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some of the unused imports and code.