Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOC-4405: Update landing page (part 2) content (CQC checkbox) #211

Merged
merged 10 commits into from
Jul 15, 2024

Conversation

masuk-kazi98
Copy link

Description

  • Introduced checkbox option for CQC ID, so users can select it if care setting is not registered
  • Rearranged question order
  • New validation for checkbox and textfield
  • Checkbox selection clears text field and vice versa
  • Content updates
  • Have had to add 'novalidate' to the form.html to override javascript validation messages that would appear on the field like the example below. This was overwriting the helpers.error message from being shown. Should not affect joi validation on other pages
    image
  • Have created TextFieldCustom (extension of TextField) component to cover this edge case of checkbox+textfield validation, as the custom helpers function would also handle all other text fields on the page. The custom text field ensures only a single text field is being handled by the component
  • The error messages will behave weirdly though. When form is submitted with no values entered for any fields, only the normal text fields will show errors. Once they are filled, and cqc text+checkbox left empty, THEN the new error message will show. Not found a workaround for this unfortunately

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally ✅

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@masuk-kazi98 masuk-kazi98 merged commit 5d0ba6b into develop Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants