Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
cgsunkel committed Feb 26, 2024
1 parent 3a0d80c commit 8aca74e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"test:unit": "NODE_ENV=test API_ROOT=http://test MOCHA_FILE=junit/test-results.xml npx mocha ./src/**/*.test.js --exit",
"test:functional": "CYPRESS_retries=3 nyc cypress run --browser chrome",
"test:a11y": "CYPRESS_coverage=false cypress run --config-file cypress.a11y.config.js --browser chrome",
"test:a11y:watch": "CYPRESS_coverage=false cypress open --config-file cypress.a11y.config.js --browser chrome",
"test:a11y:watch": "CYPRESS_coverage=false cypress open --config-file cypress.a11y.config.js --e2e --browser chrome",
"test:unit-client": "NODE_ENV=test WEBPACK_ENV=develop MOCHA_FILE=junit/test-results.xml npx mochapack --webpack-config webpack.node.config.js --opts ./test/unit-client/mocha.opts ./test/unit-client/assets/javascripts/**/*.test.{js,jsx}",
"test:functional:watch": "cypress open --e2e --browser chrome",
"test:e2e:lep": "CYPRESS_coverage=false cypress run --config '{\"specPattern\":[\"test/end-to-end/cypress/specs/LEP/**/*.js\"]}' --browser chrome",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import React from 'react'
import PropTypes from 'prop-types'
import { H3 } from 'govuk-react'
import { FONT_SIZE, FONT_WEIGHTS } from '@govuk-react/constants'
import styled from 'styled-components'

import { BLUE } from '../../../../../client/utils/colours'

const StyledActivitySubject = styled('h3')`
const StyledActivitySubject = styled(H3)`
font-size: ${FONT_SIZE.SIZE_20};
font-weight: ${FONT_WEIGHTS.bold};
line-height: ${FONT_SIZE.SIZE_24};
Expand All @@ -25,7 +26,7 @@ const ActivityCardSubject = ({
dataTest = 'activity-card-subject',
margin = { bottom: 10 },
}) => (
<StyledActivitySubject data-test={dataTest} margin={margin}>
<StyledActivitySubject data-test={dataTest} margin={margin} as="h2">
{children}
</StyledActivitySubject>
)
Expand Down
1 change: 1 addition & 0 deletions test/a11y/cypress/config/urlTestExclusions.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ export const urlTestExclusions = [
{ url: '/investments/projects/:investmentId/propositions/:propositionId' },
{ url: '/companies/:companyId/hierarchies/ghq/:globalHqId/add' },
{ url: '/companies/:companyId/hierarchies/ghq/remove' },
{ url: '/companies/:companyId' },
// 501 errors
{ url: '/api-proxy/v4/company/:companyId/export-win' },
{ url: '/investments/projects/:projectId/edit-ukcompany/:companyId' },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,8 @@ describe('Company Orders (OMIS) Collection Page', () => {
}).as('archivedApiRequest')
cy.visit(urls.companies.orders(archivedLtd.id))
assertPayload('@archivedApiRequest', {
offset: 0,
limit: 10,
sortby: 'created_on:desc',
offset: 0,
company: archivedLtd.id,
})
})
Expand Down

0 comments on commit 8aca74e

Please sign in to comment.