-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for GREAT export enquiry activity #7410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend Run #58103
Run Properties:
|
Project |
data-hub-frontend
|
Branch Review |
chore/add-tests-for-great-activity
|
Run status |
Passed #58103
|
Run duration | 01m 38s |
Commit |
97ada16176: Fix functional test
|
Committer | Christopher |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
15
|
View all changes introduced in this branch ↗︎ |
baarkerlounger
approved these changes
Dec 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7410 +/- ##
==========================================
+ Coverage 88.44% 88.54% +0.10%
==========================================
Files 1160 1159 -1
Lines 18046 18039 -7
Branches 5116 5114 -2
==========================================
+ Hits 15960 15973 +13
+ Misses 2086 2066 -20 ☔ View full report in Codecov by Sentry. |
samuele-mattiuzzo
approved these changes
Dec 17, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Dec 17, 2024
generated from commit 13be91e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We didn't have full tests around the Great activity cards so I've added some. Once this PR is merged we will have full tests for all the activities.
I have also made a couple of changes to restore the original layout:
Screenshots
Before
After
Checklist