Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for GREAT export enquiry activity #7410

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

cgsunkel
Copy link
Contributor

Description of change

We didn't have full tests around the Great activity cards so I've added some. Once this PR is merged we will have full tests for all the activities.

I have also made a couple of changes to restore the original layout:

  • Several missing fields were reinstated
  • The Notes field was originally above the rest of the metadata instead of at the end, I have fixed the order and removed the superfluous 'comment' label
  • The Contact field no longer appears if the contact's name is blank

Screenshots

Before

Screenshot 2024-12-16 at 18 29 34

After

Screenshot 2024-12-16 at 18 28 58

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@cgsunkel cgsunkel requested a review from a team as a code owner December 16, 2024 18:39
Copy link

cypress bot commented Dec 16, 2024

data-hub-frontend    Run #58103

Run Properties:  status check passed Passed #58103  •  git commit 97ada16176: Fix functional test
Project data-hub-frontend
Branch Review chore/add-tests-for-great-activity
Run status status check passed Passed #58103
Run duration 01m 38s
Commit git commit 97ada16176: Fix functional test
Committer Christopher
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (eaf00f0) to head (97ada16).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...yOverview/TableCards/ActivityCards/transformers.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7410      +/-   ##
==========================================
+ Coverage   88.44%   88.54%   +0.10%     
==========================================
  Files        1160     1159       -1     
  Lines       18046    18039       -7     
  Branches     5116     5114       -2     
==========================================
+ Hits        15960    15973      +13     
+ Misses       2086     2066      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgsunkel cgsunkel merged commit 13be91e into main Dec 17, 2024
16 checks passed
@cgsunkel cgsunkel deleted the chore/add-tests-for-great-activity branch December 17, 2024 15:00
chopkinsmade pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants