-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the value of a global account manager before it is transformed #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6739d98
to
f23b428
Compare
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
=========================================
Coverage ? 87.41%
=========================================
Files ? 336
Lines ? 5922
Branches ? 0
=========================================
Hits ? 5177
Misses ? 745
Partials ? 0
Continue to review full report at Codecov.
|
web-bert
reviewed
Mar 5, 2020
rafenden
approved these changes
Mar 5, 2020
debitan
approved these changes
Mar 5, 2020
web-bert
approved these changes
Mar 5, 2020
5c5c319
to
8c647b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR fixes a bug that causes Data Hub to hang and eventually leads to a 504 error when a user clicks on ‘View full business details’ on affected one list companies (this also appears in Sentry). An example of this can be found here - an error message should appear in the 'data-hub-sentry' channel after the link is clicked.
The bug is caused if someone using Django Admin changes a company to the one list tier but does not set the one list account owner. In the code, the translator always expects
one_list_global_account_manager
to be defined and throws an unexpected error when encountering 'null'This PR allows the transformer to check the value of
one_list_global_account_manager
before the transformation process starts, and returns a value of ‘not set’ if the variable hasn’t been set beforehand.Test instructions
Go the the company identified above in the Heroku app and the business details page should appear normally
Screenshots
Before
After
A normal business details page should appear
Checklist