Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/export win details #6460

Merged
merged 20 commits into from
Feb 28, 2024
Merged

Feat/export win details #6460

merged 20 commits into from
Feb 28, 2024

Conversation

peterhudec
Copy link
Contributor

@peterhudec peterhudec commented Jan 24, 2024 •
edited
Loading

Description of change

Adds the Export Wins Details page and updates links to it.

Test instructions

  1. Go to /exportwins
  2. Click on on the Review export win button
  3. That should navigate to /exportwins/<id>/details
  4. The page should conform to the design
  5. There should be an Export wins link on the bottom of the page, which should get you back to /exportwins

Screenshots

export-win-details-2.mov

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@peterhudec peterhudec requested a review from a team as a code owner January 24, 2024 17:13
@cypress Cypress
Copy link

cypress bot commented Jan 24, 2024 •
edited
Loading

Passing run #51458 ↗︎

0 26 0 0 Flakiness 0

Details:

Fixed failing a11y tests
Project: data-hub-frontend Commit: 28a07a6362
Status: Passed Duration: 02:09 💡
Started: Feb 28, 2024 1:30 PM Ended: Feb 28, 2024 1:32 PM

Review all test suite changes for PR #6460 ↗︎

@peterhudec peterhudec force-pushed the feat/export-win-details branch 2 times, most recently from 19fd5b7 to e755a91 Compare January 26, 2024 12:05
@DeanElliott96 DeanElliott96 self-requested a review January 30, 2024 14:00
DeanElliott96
DeanElliott96 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@DeanElliott96 DeanElliott96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your video, it looks good and code looks good to! I'm having some issues trying to run export wins on my frontend and have requested access so can't test myself atm.

Just a couple questions on the tests and the variable x.

src/client/modules/ExportWins/Details.jsx Outdated Show resolved Hide resolved
test/component/cypress/specs/ExportWins/Details.cy.jsx Show resolved Hide resolved
dredmonds
dredmonds approved these changes Feb 2, 2024
View reviewed changes
src/middleware/api-proxy.js Outdated Show resolved Hide resolved
@peterhudec peterhudec force-pushed the feat/export-win-details branch from e755a91 to 99d9c99 Compare February 27, 2024 16:50
@peterhudec
Added the api/v4/export_win endpoint to sandbox and proxy
799431b
@peterhudec
Updated the ConfirmedWinsTable to reflect
84b5027 
most recent export wins data structure changes
@peterhudec
WIP ExportWin/Detials
a0521b6
@peterhudec
Added export wins urls for edit and customer feedback
0767930
@peterhudec
Added Resource/ExportWin
eedd30e
@peterhudec
Implemented the ExportWins/Details page as per design
0d95e5d
@peterhudec
Restored the condition for confirmed win
3071d7d
@peterhudec
Implemented latest design changes
cbc6a7f
@peterhudec
Made the SummaryTable.Row stylable
00d8a84
@peterhudec
The breakdown rows have now normal font weight
2d6420b
@peterhudec
Improved coding style
48e7943
@peterhudec
Fixed import errors in sandbox
8ce0339
@peterhudec
Fixed missing fields in /v4/export_win sandbox endpoint
f1ce063
@peterhudec
Removed obsolete modules
69b5f9f
@peterhudec
Added export wins URLs to the a11y exclude list
93d354e
@peterhudec
Removed obsolete export win specs
7eed7f3
@peterhudec
Fixed wrong paths in export win resources
3b34ae1
@peterhudec
Added component tests for ExportWins/Details
74ef749
@peterhudec
Fixed the issue with missing Date responded values
bbb0500
@peterhudec peterhudec force-pushed the feat/export-win-details branch from 99d9c99 to bbb0500 Compare February 28, 2024 13:06
@DeanElliott96 DeanElliott96 self-requested a review February 28, 2024 15:04
@peterhudec peterhudec merged commit 89e49f0 into main Feb 28, 2024
16 checks passed
@peterhudec peterhudec deleted the feat/export-win-details branch February 28, 2024 15:13
chopkinsmade pushed a commit that referenced this pull request Feb 28, 2024
publish: Merge pull request #6460 from uktrade/feat/export-win-details
cbaf559 
generated from commit 89e49f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dredmonds dredmonds dredmonds approved these changes

@DeanElliott96 DeanElliott96 DeanElliott96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterhudec @DeanElliott96 @dredmonds