Company layout cleanup #6464
Merged
Company layout cleanup #6464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgsunkel
commented
Jan 26, 2024
| @@ -18,7 +18,6 @@ async function handleAddRemoveCompanyToList(req, res, next) { | |||
| listsToUpdate.push(addOrRemoveCompany(req, listId, id)) | |||
| } | |||
| await Promise.all(listsToUpdate) | |||
| req.flash('success', 'Lists changes for this company have been saved.') | |||
There was a problem hiding this comment.
This flash message is already being generated in the form
cgsunkel
force-pushed
the
chore/company-layout-cleanup
branch
from
861b15d to
69df874
Compare
Passing run #50551 ↗︎
Details:
Review all test suite changes for PR #6464 ↗︎ |
|||||||||||||||
cgsunkel
force-pushed
the
chore/company-layout-cleanup
branch
from
69df874 to
4ba228d
Compare
peterhudec
approved these changes
Jan 26, 2024
src/client/components/CompanyLocalHeader/LocalHeaderCompanyLists.jsx
Outdated
Show resolved
Hide resolved
cgsunkel
merged commit 2c6212d
into
feature-merge/company-layout-refactoring
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is a cleanup PR for the company layout refactoring work.
The following small changes have been made:
CompanyLayoutcomponent has been deleted and replaced by the new one.flashMessagesprop has been removed as these aren't being passed down through the controllers anymore.returnUrlprop to be passed down from all the company pages.CompanyLocalHeadernow gets thecsrfTokenfrom the state instead of needing it to be passed down.Test instructions
Company pages should still work as normal.
Checklist