Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete option to proposition document #6474

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

bau123
Copy link
Contributor

@bau123 bau123 commented Jan 29, 2024

Add delete for proposition document. This is to help users with document upload fails to delete and retry.

Description of change

Add delete option for proposition documents

Test instructions

Go to an investment
Select any proposition
Upload a document
Delete Document
Redirect back to proposition

Screenshots

Before

image

After

image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@bau123 bau123 requested a review from a team as a code owner January 29, 2024 15:12
Copy link

cypress bot commented Jan 29, 2024

Passing run #50720 ↗︎

0 75 7 0 Flakiness 0

Details:

update urlTestExclusion
Project: data-hub-frontend Commit: b94b252826
Status: Passed Duration: 08:12 💡
Started: Jan 31, 2024 6:49 PM Ended: Jan 31, 2024 6:57 PM

Review all test suite changes for PR #6474 ↗︎

@bau123 bau123 force-pushed the CPS-537-Propositions/Evidence-Documents-Not-Loading branch from a6a4f34 to 1c8a435 Compare January 30, 2024 17:15
Copy link
Contributor

@DeanElliott96 DeanElliott96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could maybe add some tests? What do you think?

Add delete call for proposition documents
update urlTestExclusion
@bau123 bau123 force-pushed the CPS-537-Propositions/Evidence-Documents-Not-Loading branch from 30973ac to b94b252 Compare January 31, 2024 18:44
@bau123 bau123 requested a review from DeanElliott96 February 1, 2024 14:32
Copy link
Contributor

@DeanElliott96 DeanElliott96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting and to look at tests together tomorrow.

@bau123 bau123 merged commit 1b01286 into main Feb 1, 2024
16 checks passed
@bau123 bau123 deleted the CPS-537-Propositions/Evidence-Documents-Not-Loading branch February 1, 2024 14:49
chopkinsmade pushed a commit that referenced this pull request Feb 1, 2024
…vidence-Documents-Not-Loading

generated from commit 1b01286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants