-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete option to proposition document #6474
Merged
bau123
merged 2 commits into
main
from
CPS-537-Propositions/Evidence-Documents-Not-Loading
Feb 1, 2024
Merged
Add delete option to proposition document #6474
bau123
merged 2 commits into
main
from
CPS-537-Propositions/Evidence-Documents-Not-Loading
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #50720 ↗︎
Details:
Review all test suite changes for PR #6474 ↗︎ |
dredmonds
approved these changes
Jan 29, 2024
bau123
force-pushed
the
CPS-537-Propositions/Evidence-Documents-Not-Loading
branch
from
January 30, 2024 17:15
a6a4f34
to
1c8a435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could maybe add some tests? What do you think?
src/client/modules/Investments/Projects/Propositions/DeletePropositionDocument.jsx
Show resolved
Hide resolved
Add delete call for proposition documents
update urlTestExclusion
bau123
force-pushed
the
CPS-537-Propositions/Evidence-Documents-Not-Loading
branch
from
January 31, 2024 18:44
30973ac
to
b94b252
Compare
DeanElliott96
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting and to look at tests together tomorrow.
bau123
deleted the
CPS-537-Propositions/Evidence-Documents-Not-Loading
branch
February 1, 2024 14:49
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 1, 2024
…vidence-Documents-Not-Loading generated from commit 1b01286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delete for proposition document. This is to help users with document upload fails to delete and retry.
Description of change
Add delete option for proposition documents
Test instructions
Go to an investment
Select any proposition
Upload a document
Delete Document
Redirect back to proposition
Screenshots
Before
After
Checklist