Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export wins rejected tab #6550

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Feb 22, 2024

Description of change

Adds an export wins rejected tab. A win is rejected after the customer has reviewed the win and doesn't agree with the win contents the lead officer has outlined.

Screenshots

Screenshot 2024-02-22 at 11 41 54

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner February 22, 2024 11:47
Copy link

cypress bot commented Feb 22, 2024

Passing run #51363 ↗︎

0 26 0 0 Flakiness 0

Details:

Remove duplicate a11y exclusions
Project: data-hub-frontend Commit: 0d168b5f0e
Status: Passed Duration: 02:07 💡
Started: Feb 26, 2024 5:00 PM Ended: Feb 26, 2024 5:03 PM

Review all test suite changes for PR #6550 ↗︎

@paulgain paulgain force-pushed the feature/add-export-wins-rejected-tab branch from 6f5dd55 to 22e6fc7 Compare February 23, 2024 10:47
@paulgain paulgain force-pushed the feature/add-export-wins-rejected-tab branch from 22e6fc7 to 521f49d Compare February 23, 2024 11:27
Copy link
Contributor

@DeanElliott96 DeanElliott96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, possible duplicate URL inside the urlTestExclusions.

test/a11y/cypress/config/urlTestExclusions.js Outdated Show resolved Hide resolved
@paulgain paulgain merged commit 71afd72 into main Feb 26, 2024
16 checks passed
@paulgain paulgain deleted the feature/add-export-wins-rejected-tab branch February 26, 2024 17:37
chopkinsmade pushed a commit that referenced this pull request Feb 26, 2024
swenban pushed a commit that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants