Dependabot clearout #6561
Merged
Dependabot clearout #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump cypress from 12.17.4 to 13.6.6 Bumps [cypress](https://github.com/cypress-io/cypress) from 12.17.4 to 13.6.6. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v12.17.4...v13.6.6) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update Dependabot config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christopher Sunkel <[email protected]>
Bumps [@storybook/addons](https://github.com/storybookjs/storybook/tree/HEAD/code/deprecated/addons) from 7.6.16 to 7.6.17. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/v7.6.17/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.17/code/deprecated/addons) --- updated-dependencies: - dependency-name: "@storybook/addons" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [connect-redis](https://github.com/tj/connect-redis) from 7.1.0 to 7.1.1. - [Release notes](https://github.com/tj/connect-redis/releases) - [Commits](tj/connect-redis@v7.1.0...v7.1.1) --- updated-dependencies: - dependency-name: connect-redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@reduxjs/toolkit](https://github.com/reduxjs/redux-toolkit) from 1.9.7 to 2.2.1. - [Release notes](https://github.com/reduxjs/redux-toolkit/releases) - [Commits](reduxjs/redux-toolkit@v1.9.7...v2.2.1) --- updated-dependencies: - dependency-name: "@reduxjs/toolkit" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 13.3.3 to 14.1.1. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/sass-loader@v13.3.3...v14.1.1) --- updated-dependencies: - dependency-name: sass-loader dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cgsunkel
commented
Feb 28, 2024
| @@ -69,6 +69,7 @@ export const urlTestExclusions = [ | |||
| { url: '/reminders/settings/my-tasks-task-completed/' }, | |||
| { url: '/export/' }, | |||
| { url: '/tasks/:taskId/edit' }, | |||
| { url: '/companies/:companyId/overview' }, | |||
There was a problem hiding this comment.
This test is incredibly flaky, so this page has been skipped until we start looking into these failures. The companies/:companyId URL just redirects to the overview, so this has been skipped as well.
cgsunkel
commented
Feb 28, 2024
| @@ -25,7 +25,7 @@ const history = createBrowserHistory() | |||
|
|
|||
| const store = configureStore({ | |||
| devTools: process.env.NODE_ENV === 'development', | |||
| middleware: [sagaMiddleware, routerMiddleware(history)], | |||
| middleware: () => [sagaMiddleware, routerMiddleware(history)], | |||
There was a problem hiding this comment.
The latest versions of @reduxjs/toolkit require this to be a callback
cgsunkel
commented
Feb 28, 2024
| @@ -3,7 +3,6 @@ require('dotenv').config() | |||
|
|
|||
| module.exports = defineConfig({ | |||
| video: true, | |||
| videoUploadOnPasses: false, | |||
There was a problem hiding this comment.
This videoUploadOnPasses option was deprecated by Cypress in v13
cgsunkel
commented
Feb 28, 2024
Comment on lines
+25
to
+27
| - dependency-name: webpack-dev-server # Waiting for Cypress to add support | ||
| versions: | ||
| - "> 4.15.1" |
There was a problem hiding this comment.
We can't upgrade this dependency until Cypress start supporting v5 - cypress-io/cypress#28924
Passing run #51464 ↗︎
Details:
Review all test suite changes for PR #6561 ↗︎ |
|||||||||||||||
oliverjwroberts
requested changes
Feb 28, 2024
oliverjwroberts
approved these changes
Feb 28, 2024
swenban
approved these changes
Feb 28, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 28, 2024
generated from commit 0ceff11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I've noticed we had a few open Dependabot PRs where tests known to be flaky hadn't been re-run, and a couple more with easy-to-fix breaking changes. These tests are now passing so we can upgrade these dependencies.
Checklist