Bugfix/tet 616 sub sector filter download #6574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2024 16:07
…so that it does not include the sector_depends key value pair when there is no value
Passing run #51574 ↗︎
Details:
Review all test suite changes for PR #6574 ↗︎ |
|||||||||||||||
elcct
approved these changes
Mar 4, 2024
cgsunkel
approved these changes
Mar 4, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Mar 4, 2024
…orFilterDownload generated from commit af7c189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add sub sector filtering to the company downloads
Test instructions
Go onto the companies list and choose a sector and sub-sector filter. Download the file to see that the only results should be companies that fall into both the sector and sub-sector categories. Previously when downloading you would see all companies that fell into the sector, because the sub-sector filter was being missed off the download call
Screenshots
Before
Add a screenshot
After
Add a screenshot
Checklist