Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/export wins customer journey #6580

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Conversation

peterhudec
Copy link
Contributor

Description of change

Adds the /exportwins/review/:token page which is exposed to unauthenticated users.

Test instructions

  1. Obtain a token for reviewing an export win. You can get one when you
    2. Go to /exportwins/create?company=<company-id>
    3. Start filling out the form
    4. In step 3 add yourself as a Company contact so you can receive the email with the token
    5. Ensure your email is allow-listed in GovUK Notify sandbox
    6. Fill out the rest of the form and hit submit
    7. Go to your inbox and look for an email with the subject "Export win feedback requested"
    8. In the email there should be a "Review win" link of the format /exportwins/review/<token>
  2. With the token, go to /exportwins/review/<token> (or just click the link in the email if you followed the above instruction)
  3. You should see the Export Win Review page with a big "Tell us what made a difference" headline.
  4. You should be able to load the page even if you are not logged in to DataHub, e.g. in an incognito browser window
  5. Verify that the whole feature works as specified (have look at the test)

@peterhudec peterhudec requested a review from a team as a code owner March 4, 2024 16:55
Copy link

cypress bot commented Mar 4, 2024

Passing run #51601 ↗︎

0 24 0 0 Flakiness 0

Details:

Remove the eslint-disable prettier/prettier comment
Project: data-hub-frontend Commit: c41109e6c1
Status: Passed Duration: 02:18 💡
Started: Mar 4, 2024 5:02 PM Ended: Mar 4, 2024 5:04 PM

Review all test suite changes for PR #6580 ↗︎

@peterhudec peterhudec merged commit d9d4271 into main Mar 5, 2024
16 checks passed
@peterhudec peterhudec deleted the feat/export-wins-customer-journey branch March 5, 2024 09:36
chopkinsmade pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants