Fixes an export win pagination bug #6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When posting to an endpoint using Axios any value that is null in
the payload is stripped out. This is problematic for export wins
paginated pages.
1. When we want to fetch rejected wins we use the payload { confirmed: false}
2. When we want to fetch won wins we use the payload { confirmed: true}
3. When we want to fetch sent wins we use the payload { confirmed: null}
The last API call ultimately fails.
The temporary fix is to cast null to a string "null". The proper fix is
to create an axios intereceptor which we don't have time for - tech-debt!
peterhudec
approved these changes
Mar 6, 2024
elcct
approved these changes
Mar 6, 2024
Passing run #51667 ↗︎
Details:
Review all test suite changes for PR #6585 ↗︎ |
|||||||||||||||
chopkinsmade
pushed a commit
that referenced
this pull request
Mar 6, 2024
…gination generated from commit bb60d98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When posting to an endpoint using Axios any value that is
nullin the payload is stripped out. This is problematic for export wins paginated pages.When we want to fetch export wins the following payloads apply:
{ confirmed: false}{ confirmed: true}{ confirmed: null}The last API call ultimately fails in the sense no filter is applied.
The temporary fix is to cast
nullto a string"null". The proper fix is to create an Axios interceptor which we don't have time for - tech-debt!Checklist