Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor export wins create URLs for consistency #6587

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Mar 7, 2024

Description of change

Create a win from scratch

From: /exportwins/create?company=<company-uuid>
To: /companies/<company-uuid>/export-wins/create

Create a win from an existing export project

From: /exportwins/create?company=<company-uuid>&export=<export-uuid>
To: /companies/<company-uuid>/export/<export-uuid>/export-wins/create

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner March 7, 2024 07:30
Copy link

cypress bot commented Mar 7, 2024

Passing run #51691 ↗︎

0 26 0 0 Flakiness 0

Details:

Refactor export wins create urls for consistency
Project: data-hub-frontend Commit: 8ad610c9b6
Status: Passed Duration: 02:12 💡
Started: Mar 7, 2024 8:31 AM Ended: Mar 7, 2024 8:33 AM

Review all test suite changes for PR #6587 ↗︎

@paulgain paulgain force-pushed the fix/export-win-urls branch from e98e1d7 to 2ccf93e Compare March 7, 2024 07:46
Changed: /exportwins/create?company=<company-uuid>
To: /companies/<company-uuid>/export-wins/create

Changed: /exportwins/create?company=<company-uuid>&export=<export-uuid>
To: /companies/<company-uuid>/export/<export-uuid>/export-wins/create
@paulgain paulgain force-pushed the fix/export-win-urls branch from 2ccf93e to 8ad610c Compare March 7, 2024 08:25
@paulgain paulgain merged commit 2b1632b into main Mar 7, 2024
16 checks passed
@paulgain paulgain deleted the fix/export-win-urls branch March 7, 2024 11:18
chopkinsmade pushed a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants