Fixes a bug that prevents the export win from being saved #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting an export project to an export win the transformer was incorrectly transforming the exporter_experience into an array when it should have been an object. This is problematic when the user gets to the end of the form and attempts to save, the API endpoint validation rejects the HTTP POST.
Passing run #51745 ↗︎
Details:
Review all test suite changes for PR #6591 ↗︎ |
|||||||||||||||
elcct
approved these changes
Mar 11, 2024
peterhudec
approved these changes
Mar 11, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Mar 11, 2024
…ject-to-export-win generated from commit 892f284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When converting an Export Project to an Export Win the transformer was incorrectly transforming the
exporter_experienceinto an array when it should have been an object. This is problematic when the user gets to the end of the form and attempts to save. At this point the API endpoint validation rejects the HTTP POST with a 400.Checklist