Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored thank you page to avoid using flash message #6618

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

peterhudec
Copy link
Contributor

@peterhudec peterhudec commented Mar 15, 2024

Description of change

This PR fixes some discrepancies of the export wins thank you page with the designs.

Test instructions

  1. Go to /companies/:company-id/exportwins/create to create a new export win
    • In the third step of the form set Company contacts field to a contact with your email address so you get access to the export win review token.
    • Once you receive the email, click the Review win link which should take you to /exportwins/review/:token
  2. Once on /exportwins/review/:token
  3. Select the I confirm this information is correct radio
  4. Fill out the rest of the form and finally hit the Confirm and send button
  5. It should redirect you to /exportwins/review-win/thankyou?agree=yes where you should see
    • Header with big "Export win reviewed" heading
    • A green box saying "Thank you for taking time to review this export win."
  6. Repeat steps 1 and 2
  7. Select the Some of this information needs revising radio
  8. Fill out the rest of the form and finally hit the Confirm and send button
  9. It should redirect you to /exportwins/review-win/thankyou?agree=no where you should see
    • Header with big "Export win reviewed and changes are needed"" heading
    • A green box with two paragraphs with these texts:
      1. "Thank you for reviewing this export win."
      2. "As you have asked for some changes to be made, we will review your comments and may need to contact you if we need more information."

Screenshots

Before

before-agree

before-disagree

After

after-agree

after-disagree

Copy link

cypress bot commented Mar 15, 2024

Passing run #52003 ↗︎

0 70 7 0 Flakiness 0

Details:

Refactored thank you page to avoid using flash message
Project: data-hub-frontend Commit: 884f8afc2d
Status: Passed Duration: 08:43 💡
Started: Mar 18, 2024 2:16 PM Ended: Mar 18, 2024 2:24 PM

Review all test suite changes for PR #6618 ↗︎

@peterhudec peterhudec force-pushed the export-wins-thank-you-pages branch from 69b937a to 884f8af Compare March 18, 2024 14:11
@peterhudec peterhudec marked this pull request as ready for review March 18, 2024 15:20
@peterhudec peterhudec requested a review from a team as a code owner March 18, 2024 15:20
@peterhudec peterhudec merged commit ee7ce06 into main Mar 19, 2024
16 checks passed
@peterhudec peterhudec deleted the export-wins-thank-you-pages branch March 19, 2024 09:29
chopkinsmade pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants