Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customer confidentiality radio buttons for Export Wins #6619

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Mar 15, 2024

Description of change

Export wins
Adds two radio buttons that asks the user if the customer name is confidential. If the name is confidential we assign 'confidential' to name_of_customer, if not, the user enters the customer's name which is assigned to name_of_customer and displayed on Data Hub.

Question: Is the customer's name confidential?

User answers Yes:

// Payload
name_of_customer: 'confidential'
name_of_customer_confidential: true

User answers No and enters the customer's name:

// Payload
name_of_customer: 'Joseph Lee'
name_of_customer_confidential: false

Test instructions

Go to: /companies/<company-uuid>/exportwins/create?step=win_details

Screenshots

Screenshot 2024-03-18 at 11 47 16 ## Checklist
  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner March 15, 2024 19:14
Copy link

cypress bot commented Mar 15, 2024

Passing run #52000 ↗︎

0 70 7 0 Flakiness 0

Details:

Cleanup from previous PR
Project: data-hub-frontend Commit: 9fda18a07d
Status: Passed Duration: 09:54 💡
Started: Mar 18, 2024 1:57 PM Ended: Mar 18, 2024 2:07 PM

Review all test suite changes for PR #6619 ↗︎

@paulgain paulgain force-pushed the feature/add-customer-confidential-radio-buttons branch 5 times, most recently from 732acfe to 8bf33b2 Compare March 18, 2024 12:09
@paulgain paulgain changed the title Feature/add customer confidential radio buttons Add two radio buttons around customer confidentiality (Export Wins) Mar 18, 2024
@paulgain paulgain force-pushed the feature/add-customer-confidential-radio-buttons branch from 8bf33b2 to 409b67d Compare March 18, 2024 12:51
@paulgain paulgain changed the title Add two radio buttons around customer confidentiality (Export Wins) Add customer confidentiality radio buttons for Export Wins Mar 18, 2024
@paulgain paulgain force-pushed the feature/add-customer-confidential-radio-buttons branch from 409b67d to 9fda18a Compare March 18, 2024 13:29
@paulgain paulgain merged commit 6a1e89d into main Mar 18, 2024
16 checks passed
@paulgain paulgain deleted the feature/add-customer-confidential-radio-buttons branch March 18, 2024 16:10
chopkinsmade pushed a commit that referenced this pull request Mar 18, 2024
…onfidential-radio-buttons

generated from commit 6a1e89d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants