Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date unit tests and fix a flaky test. #6627

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

paulgain
Copy link
Contributor

Description of change

Adds some unit tests around our date utility functions and fixes a flaky test.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Move the date helper functions into src/client/utils/date.js for reusability
@paulgain paulgain requested a review from a team as a code owner March 18, 2024 08:23
Copy link

cypress bot commented Mar 18, 2024

Passing run #51976 ↗︎

0 26 0 0 Flakiness 0

Details:

Add date unit tests
Project: data-hub-frontend Commit: df0ccd95ef
Status: Passed Duration: 02:14 💡
Started: Mar 18, 2024 9:20 AM Ended: Mar 18, 2024 9:22 AM

Review all test suite changes for PR #6627 ↗︎

@paulgain paulgain force-pushed the fix/functional-tests branch from 95cdd35 to 2c989d2 Compare March 18, 2024 09:08
@paulgain paulgain force-pushed the fix/functional-tests branch from 2c989d2 to df0ccd9 Compare March 18, 2024 09:14
@paulgain paulgain merged commit a56d0e7 into main Mar 18, 2024
16 checks passed
@paulgain paulgain deleted the fix/functional-tests branch March 18, 2024 12:08
chopkinsmade pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants