-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/export wins review cookie page #7008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhudec
force-pushed
the
feat/export-wins-review-cookie-page
branch
from
July 25, 2024 14:11
640e74f
to
f7ad686
Compare
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
paulgain
force-pushed
the
feat/export-wins-review-cookie-page
branch
from
August 7, 2024 09:06
ac36552
to
55c9ae6
Compare
and reorganized code
when it only appeared on the cookie page.
paulgain
force-pushed
the
feat/export-wins-review-cookie-page
branch
from
August 7, 2024 12:08
55c9ae6
to
799fc23
Compare
paulgain
approved these changes
Aug 8, 2024
cgsunkel
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small comments
Thanks Chris 👍 |
cgsunkel
approved these changes
Aug 8, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Aug 9, 2024
…w-cookie-page generated from commit 3955d1d
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
/exportwins/review/*
pages, but only if the user has not set a cookie preference before/exportwins/review/cookies
page where users can manage their cookie preference, which if set, is preserved in local storage.This PR includes cherry picked commits from #6965 and #7003 so ideally they should be merged before this PR is reviewed.Test instructions
No previous preference set
User acceptsUser rejects
cookie-preference
key set on the local storage for the host on which you are testing this feature/exportwins/review/<token>
/exportwins/review/thankyou
/exportwins/review/accesibility-statement
/exportwins/review/cookies
/exportwins/review/cookies
/exportwins/review/cookies
(you should be able to do so by clicking on the "Cookies" footer link)cookie-preference
key from the local storage in Developer Tools -> Application -> Local storage)Existing preference set in the local storage
cookie-preference
key set on the local storage for the host on which you are testing this feature (you can do so by following the steps above)/exportwins/review/<token>
/exportwins/review/thankyou
/exportwins/review/accesibility-statement
/exportwins/review/cookies
The Cookie page
cookie-preference
key set on the local storage for the host on which you are testing this feature/exportwins/review/cookies
Checklist