Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the export wins moved banner only appear on the Export tab #7182

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterhudec
Copy link
Contributor

Description of change

This PR fixes these shortcomings of #7137

  • The banner should only appear on the Export tab
  • The link text and aria label should read "see the export wins announcement"

Test instructions

  1. Go to /companies/<id>
  2. Click through all of the tabs in the main tab nav, e.g. Overview, Activity, Business detail, etc.
  3. The banner should only appear when the Export tab is selected
  4. The banner's link text and aria label should read "see the export wins announcement".

Screenshots

Before

Add a screenshot

After

Add a screenshot

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Sep 24, 2024

data-hub-frontend    Run #56050

Run Properties:  status check passed Passed #56050  •  git commit 6b76165866: Make the export wins moved banner only appear on the Export tab
Project data-hub-frontend
Branch Review fix/export-wins-moved-banner
Run status status check passed Passed #56050
Run duration 01m 39s
Commit git commit 6b76165866: Make the export wins moved banner only appear on the Export tab
Committer Peter Hudec
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant