Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an "export wins have now moved" banner to company export tab #7184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add an "export wins have now moved" banner to company export tab #7184

wants to merge 1 commit into from
+69 −2

Conversation

peterhudec
Copy link
Contributor

Description of change

Adds a banner to /companies/<id>/export page informing the users that "Historic export wins have now moved to Data Hub...", with a link to a Help Centre article.

Note

The Help Centre article is not published yet and this PR should only be merged once it is published.

Test instructions

  1. Go to /companies/<id>
  2. Click through all the tabs in the tab navigation just below the header
  3. Only if the Export tab is selected, in the page header, there should appear a banner saying "Historic export wins have now moved to Data Hub, see the export wins announcement."
  4. Where the "see the export wins announcement" part should be a link to https://data-services-help.trade.gov.uk/data-hub/updates/announcements/export-wins-has-moved-to-data-hub/

Screenshots

Before

Screenshot 2024-09-25 at 10 05 50

After

Screenshot 2024-09-25 at 10 05 06

@peterhudec peterhudec force-pushed the feat/company-page-export-win-banner branch 2 times, most recently from 175b5e4 to 43ca93e Compare September 25, 2024 09:15
@cypress Cypress
Copy link

cypress bot commented Sep 25, 2024 •
edited
Loading

data-hub-frontend    Run #57211

Run Properties:  status check passed Passed #57211  •  git commit a35f13c992: Make the export wins moved banner only appear on the Export tab
Project data-hub-frontend
Branch Review feat/company-page-export-win-banner
Run status status check passed Passed #57211
Run duration 08m 10s
Commit git commit a35f13c992: Make the export wins moved banner only appear on the Export tab
Committer Peter Hudec
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 75
View all changes introduced in this branch ↗︎

@peterhudec peterhudec marked this pull request as ready for review November 15, 2024 10:03
@peterhudec peterhudec requested a review from a team as a code owner November 15, 2024 10:03
@peterhudec peterhudec force-pushed the feat/company-page-export-win-banner branch from 43ca93e to a35f13c Compare November 15, 2024 10:05
@dredmonds dredmonds mentioned this pull request Nov 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterhudec