-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EW migration alert banner messages #7278
Conversation
data-hub-frontend Run #57540
Run Properties:
|
Project |
data-hub-frontend
|
Branch Review |
feature/EGBT-1527-EW-alert-banner-combine
|
Run status |
Passed #57540
|
Run duration | 08m 18s |
Commit |
874fe07ebf: Revert lead officer details banner message
|
Committer | Edmond De Los Reyes |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
4
|
Skipped |
0
|
Passing |
75
|
View all changes introduced in this branch ↗︎ |
3de730a
to
a80ccf9
Compare
a80ccf9
to
984b631
Compare
6c7dc0b
to
04d94c5
Compare
856651d
to
4e1d9a4
Compare
All I see is this: This meant to be in that way for |
4e1d9a4
to
d9114d7
Compare
All I see is this: Unfortunately, the design is wrong! You will notice we have removed the lead officer name field when editing an export win. We need the banner put back as it informs the user what they should do if they want to edit the lead officer name field. The design incorrectly shows the lead officer name field when editing. |
d9114d7
to
874fe07
Compare
generated from commit 1989bcf
Description of change
This PR is a consolidated implementation of Export wins migration alert banner message(see related tickets).
It will shown a flash messages on the top of local header for Pending, Confirmed and Rejected tab. Also, it tells the instruction to modify each sections of the form.
In addition, ticket https://uktrade.atlassian.net/browse/EGTB-1526 with PR #7184 also consolidated into this PR to unify in one implementation.
Mural design: https://app.mural.co/t/departmentforbusinessandtrad1574/m/departmentforbusinessandtrad1574/1719843845967/af61127b5d7ad8b8ef5587b9cd9ced47f3dedc90
Related tickets:
https://uktrade.atlassian.net/browse/EGTB-1526
https://uktrade.atlassian.net/browse/EGTB-1527
https://uktrade.atlassian.net/browse/EGTB-1528
https://uktrade.atlassian.net/browse/EGTB-1529
Test instructions
http:://localhost:3000/exportwins/
selectPending
,Confirmed
orRejected
.Screenshots
Before
After
Export Wins main dashboard
Pending Export Win - Summary
Pending Export Win - Officer details
Pending Customer details
Pending Win details
Checklist