Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EW migration alert banner messages #7278

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

dredmonds
Copy link
Contributor

@dredmonds dredmonds commented Oct 31, 2024

Description of change

This PR is a consolidated implementation of Export wins migration alert banner message(see related tickets).
It will shown a flash messages on the top of local header for Pending, Confirmed and Rejected tab. Also, it tells the instruction to modify each sections of the form.

In addition, ticket https://uktrade.atlassian.net/browse/EGTB-1526 with PR #7184 also consolidated into this PR to unify in one implementation.

Mural design: https://app.mural.co/t/departmentforbusinessandtrad1574/m/departmentforbusinessandtrad1574/1719843845967/af61127b5d7ad8b8ef5587b9cd9ced47f3dedc90

Related tickets:
https://uktrade.atlassian.net/browse/EGTB-1526
https://uktrade.atlassian.net/browse/EGTB-1527
https://uktrade.atlassian.net/browse/EGTB-1528
https://uktrade.atlassian.net/browse/EGTB-1529

Test instructions

  • Navigate into http:://localhost:3000/exportwins/ select Pending, Confirmed or Rejected.
  • Choose any Wins on the list and shown an appropriate alert banner message for export win summary, edit officer details, edit credit for this win, edit customer details, win details and support given form section.

Screenshots

Before

  • Export Wins main dashboard
    image
  • Pending Export Win
    image

After

  • Export Wins main dashboard
    image

  • Pending Export Win - Summary
    image

  • Pending Export Win - Officer details
    image

  • Pending Customer details
    image

  • Pending Win details
    image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Oct 31, 2024

data-hub-frontend    Run #57540

Run Properties:  status check passed Passed #57540  •  git commit 874fe07ebf: Revert lead officer details banner message
Project data-hub-frontend
Branch Review feature/EGBT-1527-EW-alert-banner-combine
Run status status check passed Passed #57540
Run duration 08m 18s
Commit git commit 874fe07ebf: Revert lead officer details banner message
Committer Edmond De Los Reyes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 75
View all changes introduced in this branch ↗︎

@dredmonds dredmonds force-pushed the feature/EGBT-1527-EW-alert-banner-combine branch 2 times, most recently from 3de730a to a80ccf9 Compare November 6, 2024 10:19
@dredmonds dredmonds marked this pull request as ready for review November 6, 2024 10:38
@dredmonds dredmonds requested a review from a team as a code owner November 6, 2024 10:38
@dredmonds dredmonds force-pushed the feature/EGBT-1527-EW-alert-banner-combine branch from a80ccf9 to 984b631 Compare November 7, 2024 14:07
@dredmonds dredmonds force-pushed the feature/EGBT-1527-EW-alert-banner-combine branch 4 times, most recently from 6c7dc0b to 04d94c5 Compare November 19, 2024 13:24
@dredmonds dredmonds force-pushed the feature/EGBT-1527-EW-alert-banner-combine branch 4 times, most recently from 856651d to 4e1d9a4 Compare November 21, 2024 16:42
@paulgain
Copy link
Contributor

Screenshot 2024-11-25 at 11 56 46

All I see is this:
Screenshot 2024-11-25 at 12 01 16

@dredmonds
Copy link
Contributor Author

dredmonds commented Nov 25, 2024

Screenshot 2024-11-25 at 11 56 46 All I see is this: Screenshot 2024-11-25 at 12 01 16

This meant to be in that way for Pending - Edit Officer Details, Historic export win banner will be shown. please find Mural for reference https://app.mural.co/t/departmentforbusinessandtrad1574/m/departmentforbusinessandtrad1574/1719843845967/af61127b5d7ad8b8ef5587b9cd9ced47f3dedc90

@dredmonds dredmonds force-pushed the feature/EGBT-1527-EW-alert-banner-combine branch from 4e1d9a4 to d9114d7 Compare November 26, 2024 10:02
@paulgain
Copy link
Contributor

Screenshot 2024-11-25 at 11 56 46 All I see is this: Screenshot 2024-11-25 at 12 01 16

This meant to be in that way for Pending - Edit Officer Details, Historic export win banner will be shown. please find Mural for reference https://app.mural.co/t/departmentforbusinessandtrad1574/m/departmentforbusinessandtrad1574/1719843845967/af61127b5d7ad8b8ef5587b9cd9ced47f3dedc90

Unfortunately, the design is wrong! You will notice we have removed the lead officer name field when editing an export win. We need the banner put back as it informs the user what they should do if they want to edit the lead officer name field. The design incorrectly shows the lead officer name field when editing.

@dredmonds dredmonds force-pushed the feature/EGBT-1527-EW-alert-banner-combine branch from d9114d7 to 874fe07 Compare November 28, 2024 11:31
@dredmonds dredmonds merged commit 1989bcf into main Nov 29, 2024
15 checks passed
@dredmonds dredmonds deleted the feature/EGBT-1527-EW-alert-banner-combine branch November 29, 2024 10:06
chopkinsmade pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants