WIP: feature/change-consent-detail-to-read-only #7277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopkinsmade
changed the title
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/change-contact-consent-to-read-only
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Chris Hopkins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
chopkinsmade
force-pushed
the
feature/change-consent-detail-to-read-only
branch
9 times, most recently
from
8f85ff3 to
3cce0a0
Compare
chopkinsmade
force-pushed
the
feature/change-consent-detail-to-read-only
branch
2 times, most recently
from
0a406de to
80650a2
Compare
chopkinsmade
force-pushed
the
feature/change-consent-detail-to-read-only
branch
from
80650a2 to
af61a75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7277 +/- ##
=======================================
Coverage 87.99% 88.00%
=======================================
Files 1168 1170 +2
Lines 18171 18214 +43
Branches 5139 5153 +14
=======================================
+ Hits 15990 16029 +39
- Misses 2181 2185 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add a new table on the contact page showing their consent data
Test instructions
Running the frontend locally, connected to a local instance of the API, these 2 examples can be used for testing:
Screenshots
Before
After
Add a screenshot
Checklist