-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/event details page #7375
Open
peterhudec
wants to merge
15
commits into
main
Choose a base branch
from
refactor/event-details-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend Run #57945
Run Properties:
|
Project |
data-hub-frontend
|
Branch Review |
refactor/event-details-page
|
Run status |
Passed #57945
|
Run duration | 01m 45s |
Commit |
35768a25e9: Fixed a typo
|
Committer | Peter Hudec |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
15
|
View all changes introduced in this branch ↗︎ |
peterhudec
force-pushed
the
refactor/event-details-page
branch
2 times, most recently
from
December 10, 2024 16:11
fe49d8c
to
318ad07
Compare
instead of calling getMessages() arbitrarily
peterhudec
force-pushed
the
refactor/event-details-page
branch
from
December 12, 2024 13:38
318ad07
to
f6e1fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR refactors the
/events/{id}/details
and/events/{id}/attendees
paths to React. It also fixes:{event-name}
(previously it was "Events" when on the/events/{id}/details
} pageTest instructions
/events
/events/{id}/details
/events/{id}/attendees
, without page reloading/events/{id}/details
, without page reloadingScreenshots
Before
After