Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/event details page #7375

Merged
merged 17 commits into from
Jan 16, 2025
Merged

Refactor/event details page #7375

merged 17 commits into from
Jan 16, 2025

Conversation

peterhudec
Copy link
Contributor

Description of change

This PR refactors the /events/{id}/details and /events/{id}/attendees paths to React. It also fixes:

  • Missing trailing segments in breadcrumbs
  • The title in the header is now always the {event-name} (previously it was "Events" when on the /events/{id}/details} page

Test instructions

  1. Go to /events
  2. Click on one of the events
  3. You should land on /events/{id}/details
  4. Click on the Attendees item on the left hand side navigation
  5. You should see
    • The Attendees side bar navigation item highlighted as selected
    • Path in the address bar to have changed to /events/{id}/attendees, without page reloading
    • A list of attendees to the right of the sidebar
    • The breadcrumbs should be Home > Events > {event-title} > Attendees
  6. Click on the Details nav item
  7. You should see
    • The Details side bar navigation item highlighted as selected
    • Path in the address bar to have changed to /events/{id}/details, without page reloading
    • The event details table to the right of the sidebar
    • The breadcrumbs should be Home > Events > {event-name} > Details

Screenshots

Before

Screenshot 2024-12-06 at 10 49 09

After

Screenshot 2024-12-06 at 10 48 38

@peterhudec peterhudec requested a review from a team as a code owner December 6, 2024 10:50
Copy link

cypress bot commented Dec 6, 2024

data-hub-frontend    Run #58639

Run Properties:  status check passed Passed #58639  •  git commit c2bc676684: Move attendee sort options to a constant
Project data-hub-frontend
Branch Review refactor/event-details-page
Run status status check passed Passed #58639
Run duration 01m 40s
Commit git commit c2bc676684: Move attendee sort options to a constant
Committer Peter Hudec
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

@peterhudec peterhudec force-pushed the refactor/event-details-page branch 3 times, most recently from 318ad07 to f6e1fb5 Compare December 12, 2024 13:38
@peterhudec peterhudec force-pushed the refactor/event-details-page branch 2 times, most recently from 80279aa to 77e02ea Compare January 9, 2025 15:40
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.58%. Comparing base (1644867) to head (c2bc676).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/client/modules/Events/EventDetails/index.jsx 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7375      +/-   ##
==========================================
- Coverage   88.63%   88.58%   -0.05%     
==========================================
  Files        1161     1152       -9     
  Lines       18014    17963      -51     
  Branches     5127     5121       -6     
==========================================
- Hits        15967    15913      -54     
- Misses       2047     2050       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterhudec peterhudec force-pushed the refactor/event-details-page branch from e02ab86 to c2bc676 Compare January 14, 2025 11:01
@peterhudec peterhudec merged commit 25a7eb9 into main Jan 16, 2025
16 checks passed
@peterhudec peterhudec deleted the refactor/event-details-page branch January 16, 2025 09:10
chopkinsmade pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants