-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/event details page #7375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
Project |
data-hub-frontend
|
Branch Review |
refactor/event-details-page
|
Run status |
|
Run duration | 01m 40s |
Commit |
|
Committer | Peter Hudec |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
15
|
View all changes introduced in this branch ↗︎ |
318ad07
to
f6e1fb5
Compare
80279aa
to
77e02ea
Compare
baarkerlounger
approved these changes
Jan 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7375 +/- ##
==========================================
- Coverage 88.63% 88.58% -0.05%
==========================================
Files 1161 1152 -9
Lines 18014 17963 -51
Branches 5127 5121 -6
==========================================
- Hits 15967 15913 -54
- Misses 2047 2050 +3 ☔ View full report in Codecov by Sentry. |
dredmonds
approved these changes
Jan 13, 2025
instead of calling getMessages() arbitrarily
e02ab86
to
c2bc676
Compare
chopkinsmade
pushed a commit
that referenced
this pull request
Jan 16, 2025
…-page generated from commit 25a7eb9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR refactors the
/events/{id}/details
and/events/{id}/attendees
paths to React. It also fixes:{event-name}
(previously it was "Events" when on the/events/{id}/details
} pageTest instructions
/events
/events/{id}/details
/events/{id}/attendees
, without page reloading/events/{id}/details
, without page reloadingScreenshots
Before
After