Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/event details page #7375

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

peterhudec
Copy link
Contributor

Description of change

This PR refactors the /events/{id}/details and /events/{id}/attendees paths to React. It also fixes:

  • Missing trailing segments in breadcrumbs
  • The title in the header is now always the {event-name} (previously it was "Events" when on the /events/{id}/details} page

Test instructions

  1. Go to /events
  2. Click on one of the events
  3. You should land on /events/{id}/details
  4. Click on the Attendees item on the left hand side navigation
  5. You should see
    • The Attendees side bar navigation item highlighted as selected
    • Path in the address bar to have changed to /events/{id}/attendees, without page reloading
    • A list of attendees to the right of the sidebar
    • The breadcrumbs should be Home > Events > {event-title} > Attendees
  6. Click on the Details nav item
  7. You should see
    • The Details side bar navigation item highlighted as selected
    • Path in the address bar to have changed to /events/{id}/details, without page reloading
    • The event details table to the right of the sidebar
    • The breadcrumbs should be Home > Events > {event-name} > Details

Screenshots

Before

Screenshot 2024-12-06 at 10 49 09

After

Screenshot 2024-12-06 at 10 48 38

@peterhudec peterhudec requested a review from a team as a code owner December 6, 2024 10:50
Copy link

cypress bot commented Dec 6, 2024

data-hub-frontend    Run #57945

Run Properties:  status check passed Passed #57945  •  git commit 35768a25e9: Fixed a typo
Project data-hub-frontend
Branch Review refactor/event-details-page
Run status status check passed Passed #57945
Run duration 01m 45s
Commit git commit 35768a25e9: Fixed a typo
Committer Peter Hudec
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

@peterhudec peterhudec force-pushed the refactor/event-details-page branch 2 times, most recently from fe49d8c to 318ad07 Compare December 10, 2024 16:11
@peterhudec peterhudec force-pushed the refactor/event-details-page branch from 318ad07 to f6e1fb5 Compare December 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant