Remove formatWithoutParsing function and replace it with formatDate
#7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
fix/remove-format-without-parsing
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Paul Gain |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
paulgain
force-pushed
the
fix/remove-format-without-parsing
branch
2 times, most recently
from
1f2ccc7 to
cf0a0a0
Compare
paulgain
force-pushed
the
fix/remove-format-without-parsing
branch
from
cf0a0a0 to
547e907
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7395 +/- ##
==========================================
+ Coverage 88.01% 88.18% +0.17%
==========================================
Files 1167 1168 +1
Lines 18139 18132 -7
Branches 5136 5127 -9
==========================================
+ Hits 15965 15990 +25
+ Misses 2174 2142 -32 ☔ View full report in Codecov by Sentry. |
baarkerlounger
approved these changes
Dec 13, 2024
peterhudec
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Looks good, but I left a number of suggestions:
- The ergonomics of
formatDatecould be greatly improved if the format presets were a map and we leveraged TypeScript in JSDoc - I wouldn't use
formatDatein test assertions
Approving it anyway as I don't wanna block it while I'm gonna be off for until new year.
src/client/components/InvestmentReminders/OutstandingPropositions.jsx
Outdated
Show resolved
Hide resolved
src/client/components/MyInvestmentProjects/InvestmentEstimatedLandDate.jsx
Outdated
Show resolved
Hide resolved
chopkinsmade
pushed a commit
that referenced
this pull request
Dec 16, 2024
…out-parsing generated from commit 79df8cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR simplifies the use of date utilities by replacing all instances of
formatWithoutParsingwithformatDate. Importantly, it introduces the practice of importingdate-fnsfunctions directly in source files, bypassing the centraliseddate.jsmodule. This change reduces the reliance on redundant wrappers like those indate.js, making the codebase cleaner and more maintainable. In a subsequent PR, the remainingdate.jswrappers and imports fromdate-fnswill be removed entirely.Checklist