Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/CLS2-981 Display EYB activity on Company Overview page #7396

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

swenban
Copy link
Contributor

@swenban swenban commented Dec 12, 2024

Description of change

Document what the PR does and why the change is needed

Test instructions

What should I see?

Screenshots

Before

Add a screenshot

After

Add a screenshot

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Dec 12, 2024

data-hub-frontend    Run #58133

Run Properties:  status check passed Passed #58133  •  git commit 210a86ae54: Display linked company name if it exists
Project data-hub-frontend
Branch Review feature/CLS2-981-display-eyb-activity-info-on-company-overview-page
Run status status check passed Passed #58133
Run duration 09m 39s
Commit git commit 210a86ae54: Display linked company name if it exists
Committer Sophie Wenban
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 75
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (7328aad) to head (210a86a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...yOverview/TableCards/ActivityCards/transformers.js 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7396      +/-   ##
==========================================
+ Coverage   88.48%   88.51%   +0.02%     
==========================================
  Files        1160     1160              
  Lines       18046    18070      +24     
  Branches     5116     5123       +7     
==========================================
+ Hits        15968    15994      +26     
+ Misses       2078     2076       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swenban swenban force-pushed the feature/CLS2-981-display-eyb-activity-info-on-company-overview-page branch from 5f9a66c to c5083ba Compare December 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant