Remove format function and replace with formatDate
#7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgain
force-pushed
the
fix/replace-format-with-format-date
branch
from
0d1f14f to
5bc7062
Compare
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
fix/replace-format-with-format-date
|
| Run status |
|
| Run duration | 08m 15s |
| Commit |
|
| Committer | Paul Gain |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
75
|
| View all changes introduced in this branch ↗︎ | |
paulgain
force-pushed
the
fix/replace-format-with-format-date
branch
from
c9fdae6 to
2c46ab9
Compare
paulgain
force-pushed
the
fix/replace-format-with-format-date
branch
from
20f914d to
d278390
Compare
paulgain
force-pushed
the
fix/replace-format-with-format-date
branch
from
07b69c7 to
ae050e2
Compare
…ding the use of formatDate instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR simplifies the use of date utilities by replacing instances of
formatwithformatDate.There are still a few remaining
formatfunctions that require further refactoring in the following files:src/apps/transformers.jssrc/client/transformers/index.jssrc/client/utils/date.jssrc/config/nunjucks/trade-elements-filters.jsThese will be addressed in a future PR, for now I've deprecated the
formatfunction.Checklist