Skip to content

Commit

Permalink
Redo linting (#358)
Browse files Browse the repository at this point in the history
switch flake8 and isort for ruff
add djlint to ci-based checking
tidy up makefile
run full linting on the proejct
  • Loading branch information
marcelkornblum authored Apr 21, 2023
1 parent 683c639 commit bcb64eb
Show file tree
Hide file tree
Showing 102 changed files with 1,800 additions and 1,895 deletions.
41 changes: 15 additions & 26 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,20 @@ jobs:
name: build containers
command: make build
- run:
name: install npm packages
command: |
nvm install 18
npm ci
name: check linting
command: make check
- run:
name: build webpack
command: npm run build
name: run containers
command: docker-compose up -d
- run:
name: check for missing migrations
command: make checkmigrations
- run:
name: run black (code formatting check)
command: make black-check
- run:
name: run isort
command: make isort-check
- run:
name: run flake8 (coding standards compliance test)
command: make flake8
- run:
name: run containers
command: docker-compose up -d
name: build frontend
command: |
nvm install 18
npm ci
npm run build
- run:
name: run unit tests
command: make test
Expand All @@ -43,9 +35,6 @@ jobs:
command: |
wget -O codecov.sh https://codecov.io/bash
bash ./codecov.sh -t ${CODECOV_TOKEN} -s test-reports -f "*.xml"
- run:
name: Check for fixme comments
command: make check-fixme
e2e-tests:
machine:
image: ubuntu-2004:202101-01
Expand All @@ -56,19 +45,19 @@ jobs:
name: Copy env file
command: cp .env.ci .env
- run:
name: install npm packages
command: npm ci
- run:
name: build webpack
command: npm run build
name: build frontend
command: |
nvm install 18
npm ci
npm run build
- run:
name: build containers
command: make build-all
- run:
name: run e2e tests (playwright)
command: make test-e2e
- run:
name: Publish unit test coverage
name: Publish e2e test coverage
command: |
wget -O codecov.sh https://codecov.io/bash
bash ./codecov.sh -t ${CODECOV_TOKEN} -s test-reports -f "*.xml"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ __pycache__
.venv/
.pytest_cache/
.python-version
.ruff_cache

/node_modules
npm-debug.log*
Expand Down
Loading

0 comments on commit bcb64eb

Please sign in to comment.