Fix dockerfile to default to latest node (#344)

uktrade · Mar 28, 2023 · eed3880 · eed3880
1 parent 084c878
commit eed3880
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -10,8 +10,7 @@ ENV PYTHONSTARTUP=.pythonrc.py
 ENV POETRY_VIRTUALENVS_CREATE=false
 
 # Install Python & Node
-RUN curl -sL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - && \
-    apt-get update && apt-get install -y --no-install-recommends \
+RUN apt-get update && apt-get install -y --no-install-recommends \
     # Install general packages
     git nano \
     curl wget gpg \
@@ -22,10 +21,10 @@ RUN curl -sL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - && \
     # Install python and supporting packages
     python${PYTHON_VERSION} \
     python${PYTHON_VERSION}-dev \
-    python3-pip \
+    python3-pip && \
     # Install Node
-    nodejs \
-    npm && \
+    curl -sL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - && \
+    apt-get install -y --no-install-recommends nodejs && \
     # Setup python symlinks
     rm -rf /usr/bin/python3 && \
     ln -s /usr/bin/python${PYTHON_VERSION} /usr/bin/python3 && \

diff --git a/test.dockerfile b/test.dockerfile
@@ -8,6 +8,3 @@ RUN poetry run playwright install-deps
 RUN poetry run playwright install
 
 COPY . ./
-RUN cp .env.ci .env
-
-RUN npm ci && npm run build