Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWPF-769 Preferred name field optional #453

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

nicopicchio
Copy link
Contributor

No description provided.

@nicopicchio nicopicchio requested a review from CamLamb September 19, 2023 11:07
@marcelkornblum
Copy link
Contributor

@nicopicchio just a note to check if this field counts towards the "100% complete" calculation - I got the impression it did and that needs to be changed as well, though it wasn't noted

@nicopicchio
Copy link
Contributor Author

@marcelkornblum I don't think it counts towards the profile completion percentage.
It appears that the only sections that count towards that are Photo, Primary phone number, Location, Remore working and Manager.
image

Copy link
Contributor

@CamLamb CamLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this deployed to dev for review

Copy link
Contributor

@CamLamb CamLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicopicchio nicopicchio merged commit a54fcfc into main Sep 20, 2023
1 check passed
@nicopicchio nicopicchio deleted the DWPF-769-make-preferred-name-optional branch September 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants