fixed hint display and added exceptiopn for no email recipients

uktrade · Apr 11, 2023 · 591be19 · 591be19
1 parent 373c38c
commit 591be19
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/django_feedback_govuk/forms.py b/django_feedback_govuk/forms.py
@@ -36,13 +36,7 @@ def __init__(self, *args, **kwargs):
                 legend_size=Size.MEDIUM,
             ),
             Fieldset(
-                HTML(
-                    (
-                        "<p class='govuk-hint'>",
-                        dfg_settings.COPY_FIELD_COMMENT_HINT,
-                        "</p>",
-                    )
-                ),
+                HTML(f"<p class='govuk-hint'>{dfg_settings.COPY_FIELD_COMMENT_HINT}</p>"),
                 Field("comment"),
                 legend=dfg_settings.COPY_FIELD_COMMENT_LEGEND,
                 legend_size=Size.MEDIUM,

diff --git a/django_feedback_govuk/notify.py b/django_feedback_govuk/notify.py
@@ -12,6 +12,9 @@ def email(personalisation: Dict):
     )
     email_addresses = dfg_settings.FEEDBACK_NOTIFICATION_EMAIL_RECIPIENTS
 
+    if len(email_addresses) < 1:
+        raise Exception("No feedback recipients configured")
+
     for email_address in email_addresses:
         message_response = notification_client.send_email_notification(
             email_address=email_address,

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-feedback-govuk"
-version = "0.1.1"
+version = "0.1.2"
 description = "A Django app to gather and send internal Government staff feedback"
 authors = ["jafacakes2011 <[email protected]>", "marcelkornblum <[email protected]>"]
 license = "MIT"