Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT-104 Validation for Add Vacancy form #544

Merged
merged 4 commits into from
Nov 18, 2024
Merged

FFT-104 Validation for Add Vacancy form #544

merged 4 commits into from
Nov 18, 2024

Conversation

CaitBarnard
Copy link
Contributor

@CaitBarnard CaitBarnard commented Nov 14, 2024 •
edited
Loading

  • Non required char fields have validation to allow numbers, letters and spaces only and relevant error messaging
  • Required fields without a default now have more specific error messaging

//

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

@CaitBarnard CaitBarnard requested a review from a team as a code owner November 14, 2024 15:22
@CaitBarnard CaitBarnard changed the title FFT-104 Validation for Add Vacancy table FFT-104 Validation for Add Vacancy form Nov 14, 2024
@CaitBarnard CaitBarnard changed the base branch from main to sprint-48 November 14, 2024 15:22
SamDudley
SamDudley reviewed Nov 18, 2024
View reviewed changes
payroll/templates/payroll/page/add_vacancy.html Outdated Show resolved Hide resolved
payroll/validators.py Outdated Show resolved Hide resolved
payroll/forms.py Outdated Show resolved Hide resolved
payroll/forms.py Outdated Show resolved Hide resolved
@CaitBarnard CaitBarnard force-pushed the add-vacancy-validation branch from bf34f02 to 948af94 Compare November 18, 2024 12:18
@CaitBarnard CaitBarnard merged commit db9d16d into sprint-48 Nov 18, 2024
1 check passed
@CaitBarnard CaitBarnard deleted the add-vacancy-validation branch November 18, 2024 15:11
SamDudley pushed a commit that referenced this pull request Nov 21, 2024
@CaitBarnard @SamDudley
FFT-104 Validation for Add Vacancy form (#544)
664b43d
@SamDudley SamDudley mentioned this pull request Nov 22, 2024
Merged
SamDudley pushed a commit that referenced this pull request Dec 6, 2024
@CaitBarnard @SamDudley
FFT-104 Validation for Add Vacancy form (#544)
0a24c08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamDudley SamDudley SamDudley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaitBarnard @SamDudley