Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change selenium docker image and refactor tests #545

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Change selenium docker image and refactor tests #545

merged 3 commits into from
Nov 18, 2024

Conversation

CaitBarnard
Copy link
Contributor

Update image from Chrome to Chromium so that it will work with ARM

Remove duplication in slow pytest file

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

@CaitBarnard CaitBarnard requested a review from a team as a code owner November 15, 2024 17:02
@SamDudley SamDudley changed the title Tech debt: Change docker image to Chromium and optimise pytest file Change selenium docker image and refactor tests Nov 18, 2024
SamDudley
SamDudley approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@SamDudley SamDudley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CaitBarnard CaitBarnard merged commit c8fc4c3 into main Nov 18, 2024
4 checks passed
@CaitBarnard CaitBarnard deleted the tech-debt/testing branch November 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamDudley SamDudley SamDudley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaitBarnard @SamDudley